search

ARMmbed / mbed-os-tf-m-regression-tests

An Mbed OS application that runs the TF-M regression tests
2 stars 12 forks source link

Support multi-level TF-M target name #85

Closed ccli8 closed 3 years ago

ccli8 commented 3 years ago

I am enabling TF-M/Mbed integration on Nuvoton's M2354 target. Currently, M2354 port has landed into TF-M repo. To enable Mbed/TF-M 1.2 integration on M2354, I base on this repo's tf-m-v1.2-integration branch. Slight different, compared to 1-level TF-M target name musca_b1 or musca_s1, M2354's TF-M target name is 2-level nuvoton/m2354. Currently, I find s_veneers.o source copy path is incorrect for multi-level TF-M target name

https://github.com/ARMmbed/mbed-os-tf-m-regression-tests/blob/328ea8efc6a24c00c60dcfc033eee168737e3159/build_tfm.py#L351

It should correct to below for 2-level TF-M target name:

        install_dir = abspath(join(source, os.pardir, os.pardir, os.pardir))
jainvikas8 commented 3 years ago

Thanks for raising this issue, please can you raise a PR against - https://github.com/ARMmbed/mbed-os-tf-m-regression-tests/tree/tf-m-v1.2-integration with the recommended fix?

jainvikas8 commented 3 years ago

Closing the issue as the PR got merged.