search

ARMmbed / mbed-os-tools

The tools to test and work with Mbed OS
Apache License 2.0
33 stars 67 forks source link

Add micro:bit board IDs #277

Open mbrossard opened 2 years ago

mbrossard commented 2 years ago

Description

Add micro:bit board IDs to platform database.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@MarceloSalazar @Patater

MarceloSalazar commented 2 years ago

I'm afraid we can't have duplicates in the database.

Board IDs and targets should only be added once the names are confirmed and expected to be publicly released in the future.

mbrossard commented 2 years ago

I'm afraid we can't have duplicates in the database.

There are precedents (K64F, LPC11U24, LPC1347, LPC4330_M4).

Board IDs and targets should only be added once the names are confirmed and expected to be publicly released in the future.

Support is publicly available: https://github.com/microbit-foundation/mbedos-microbit-v2-starter

CC: @microbit-carlos, @jaustin

flit commented 2 years ago

@MarceloSalazar These are not duplicates, they reflect different board revisions and pop options. micro:bit tools use the different board IDs to automatically provide users with the correct software components.

Having distinct IDs is the only option since there is no other way to encode a board revision in the board ID. (Even CMSIS-DAP v2.1 doesn't add a board revision field to DAP_Info, although I'm proposing this be added.)