search

ARMmbed / mbed-os

Arm Mbed OS is a platform operating system designed for the internet of things
https://mbed.com
Other
4.68k stars 2.99k forks source link

COMPONENT_FPGA_CI_TEST_SHIELD: FLASH_SECTOR_SIZE macro redefinition #12675

Closed jeromecoutant closed 3 years ago

jeromecoutant commented 4 years ago

Description of defect

FLASH_SECTOR_SIZE is already used by several targets:

https://github.com/ARMmbed/mbed-os/blob/539cf3fa6396dd3a6b0377e715d7b0d40c7af4c4/components/testing/COMPONENT_FPGA_CI_TEST_SHIELD/MbedTester.cpp#L33

targets/TARGET_ARM_FM/TARGET_FVP_MPS2/flash_api.c:#define FLASH_SECTOR_SIZE 0x1000
targets/TARGET_ARM_SSG/TARGET_CM3DS_MPS2/flash_api.c:#define FLASH_SECTOR_SIZE 0x1000
targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_GR_LYCHEE/mbed_drv_cfg.h:#define FLASH_SECTOR_SIZE          4096           /**< Flash Memory sector size (interleaving off) */
targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_RZ_A1H/mbed_drv_cfg.h:#define FLASH_SECTOR_SIZE          4096           /**< Flash Memory sector size (interleaving off) */
targets/TARGET_Realtek/TARGET_AMEBA/TARGET_MCU_RTL8195A/ota_api.h:#define FLASH_SECTOR_SIZE    0x1000
targets/TARGET_Realtek/TARGET_AMEBA/sdk/soc/realtek/8195a/fwlib/rtl8195a/rtl8195a.h:#define FLASH_SECTOR_SIZE                           0x1000
targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H743xI/device/stm32h743xx.h:#define FLASH_SECTOR_SIZE  0x00020000UL        /* 128 KB */
targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/device/stm32h747xx.h:#define FLASH_SECTOR_SIZE  0x00020000UL        /* 128 KB */

I think you should rename it

Thx

Target(s) affected by this defect ?

All

Toolchain(s) (name and version) displaying this defect ?

All

What version of Mbed-os are you using (tag or sha) ?

mbed-os-6.0.0-alpha-3

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

NA

How is this defect reproduced ?

Compilation warning:

Compile [  1.4%]: MbedTester.cpp
[Warning] MbedTester.cpp@33,9: 'FLASH_SECTOR_SIZE' macro redefined [-Wmacro-redefined]
ciarmcom commented 4 years ago

@jeromecoutant thank you for the update.It appears however that there is still some missing information:

We cannot automatically identify a release based on the version of Mbed OS that you have provided. Please provide either a single valid sha of the form #abcde12 or #3b8265d70af32261311a06e423ca33434d8d80de or a single valid release tag of the form mbed-os-x.y.z . E.g. 'mbed-os-99.99.99' signifies master branch and is not a unique single snapshot. Please update the issue header with the missing information. NOTE: If there are fields which are not applicable then please just add 'n/a' or 'None'.This indicates to us that at least all the fields have been considered.

0xc0170 commented 4 years ago

This is one of the reasons why I would use regular variable in unnamed namespace rather than a macro (plus if a macro, should be prefixed, for example MBED_TESTER_. We should fix this

cc @mprse @maciejbocianski @fkjagodzinski

ciarmcom commented 4 years ago

Internal Jira reference: https://jira.arm.com/browse/IOTOSM-465

jeromecoutant commented 4 years ago

ping

MarceloSalazar commented 3 years ago

Fixed in #14076