search

ARMmbed / mbed-os

Arm Mbed OS is a platform operating system designed for the internet of things
https://mbed.com
Other
4.68k stars 2.98k forks source link

cmsis: targets still use cmsis_os.h (emac, target hal) #13756

Closed 0xc0170 closed 3 years ago

0xc0170 commented 4 years ago

Description of defect

cmsis_os header file (cmsis_os.h) is for CMSIS_RTOS version 1. We migrated to version 2 few years back. the old header is still available in CMSIS_5 but we should not reference it (migrate the code to the new CMSIS-RTOS version 2). Otherwise any new target that is created can just copy-paste it's parent and still use the old version of this header.

https://www.keil.com/pack/doc/CMSIS/RTOS2/html/os2MigrationGuide.html - same suggested in the migration guide, use cmsis_os2.h instead.

Offenders found:

emac target code - couple of mentions there - cc @ARMmbed/mbed-os-connectivity Samsung HAL @ARMmbed/team-samsung

Target(s) affected by this defect ?

Couple of targets

Toolchain(s) (name and version) displaying this defect ?

All

What version of Mbed-os are you using (tag or sha) ?

mbed-os-6.3.0

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

Not relevant

How is this defect reproduced ?

Search for "cmsis_os.h" in the Mbed OS codebase and find all mentions.

ciarmcom commented 4 years ago

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers. Internal Jira reference: https://jira.arm.com/browse/IOTOSM-2409

0xc0170 commented 3 years ago

@ARMmbed/team-samsung please review

0xc0170 commented 3 years ago

I assign this to the connectivity component, if we can clean it there, the target code can come afterwards.

ciarmcom commented 3 years ago

We closed this issue because it has been inactive for quite some time and we believe it to be low priority. If you think that the priority should be higher, then please reopen with your justification for increasing the priority.