ARMmbed / mbed-os

Arm Mbed OS is a platform operating system designed for the internet of things
https://mbed.com
Other
4.67k stars 2.98k forks source link

Sync with CMSIS repo / allow use of CMSIS-DSP #5700

Closed bmcdonnell-ionx closed 5 years ago

bmcdonnell-ionx commented 6 years ago

Description


Enhancement

Reason to enhance or problem with existing solution

There is no straightforward or maintainable way to utilize the parts of CMSIS which are not already included by mbed-os, e.g. CMSIS-DSP.

This is due to the subset of files chosen from the CMSIS repo, which are taken from different revisions of the CMSIS repo, organized in a different folder structure, and further customized within mbed-os. (In my working copy of mbed-os, I did git log --all --graph --decorate cmsis to investigate this. I'm not aware of those customizations being pushed upstream.)

Suggested enhancement

Pros

Cons

bmcdonnell-ionx commented 6 years ago

For the record, I noticed that CMSIS-DSP appears to be located under mbed-os/features/unsupported/dsp. How can I include this in my build? [Mirrored to Jira]

0xc0170 commented 6 years ago

@ARMmbed/mbed-os-core Please review [Mirrored to Jira]

SenRamakri commented 6 years ago

@deepikabhavnani @c1728p9 @bulislaw @kegilbert - Adding team for review. [Mirrored to Jira]

deepikabhavnani commented 6 years ago

@bmcdonnell-ionx - Appreciate your inputs on enhancements. For now, if you want to know all the changes in Mbed OS from CMSIS please refer to https://github.com/ARMmbed/mbed-os/blob/master/tools/importer/cmsis_importer.json#L2. We try to keep the json script up to date, it captures all the files picked from CMSIS repo, and SHA of change commits applied on top of CMSIS.

[Mirrored to Jira]

geky commented 6 years ago

@mbartling, weren't you looking into using the DSP module with mbed-os at one point? [Mirrored to Jira]

adbridge commented 6 years ago

Internal Jira reference: https://jira.arm.com/browse/IOTCORE-302

SenRamakri commented 5 years ago

@bmcdonnell-ionx - Thanks for raising this issue and we have copied this issue into our internal project tracker. Unfortunately, we don't have plans to immediately address this issue. At this point, I would like to close this out as we may address this in only in future as to how to support CMSIS-DSP library. Please note that if multiple developers start seeing this is a blocking issue we can raise the priority to address this sooner as well. Let us know if you have more feedback on this,

bmcdonnell-ionx commented 5 years ago

@SenRamakri, since you do still plan to address it (right?), please consider leaving this issue open for visibility purposes.

SenRamakri commented 5 years ago

@bmcdonnell-ionx - Sorry I was not clear. We don't have "plans" to work on this as I mentioned previously. But it has been captured into our "Good ideas/features list" which we use to pick features to be implemented in future based on priority. The reason I wanted to close this out is there is no guarantee that this will get done and it may provide a false impression that we are working on this. Hope that helps.

bmcdonnell-ionx commented 5 years ago

@SenRamakri, bummer, but understood. Thanks.