search

ARMmbed / mbed-os

Arm Mbed OS is a platform operating system designed for the internet of things
https://mbed.com
Other
4.67k stars 2.98k forks source link

VK RZ A1H: needs an update from RZ A1H (cmsis, rtos related) #5777

Closed 0xc0170 closed 6 years ago

0xc0170 commented 6 years ago

Description

Bug

VK RZ A1H target requires an update. As it does not share the same codebase, but very identical implementation, it needs to be updated to be re-enabled. I fixed few errors there, and stopped at MMU and cache settings in the startup (cmsis updated their API, and RZ A1H changed few things in the startup) - as they become more difficult to fix. As result, it was temporarily disabled for the release 5.7.2.

It would be much easier if they share as much common code as they could. As they don't, we either patch the current implementation, or start sharing the common one to get the updates from RZ A1H.

Related: https://github.com/ARMmbed/mbed-os/pull/5770 - this one fixes some issues we found.

cc @TomoYamanaka @mbedNoobNinja Please review and help

TomoYamanaka commented 6 years ago

@0xc0170

Thank you for your cooporation.

@mbedNoobNinja

Could you acept to do this? I addressed the updates regarding to RZ_A1H by #5628. By referencing with this, I believe that you can take a action of updates VK_RZ_A1H with comparative ease.

For your information, I suggested the new folder structiures to share common codes previously(#4440). I will PR this changes together with adding our new target board(GR-LYCHEE) soon.

Therefore, After our this PR passed, I hope that you PR the changes regarding VK_RZ_A1H.

Make a sense? Please let me know if there is an unclear point.

0xc0170 commented 6 years ago

I will PR this changes together with adding our new target board(GR-LYCHEE) soon.

👍 If we can align those 3 at the same time, it would be good.

mbedNoobNinja commented 6 years ago

Hi @TomoYamanaka I actually was looking forward the PR from (#4440) and your board (GR-LYCHEE). I would be about to start comparing them after the PR in question is made. But if there is no such PR, what should I compare? (#5628 & the current state of VK_RZ_A1H)?

TomoYamanaka commented 6 years ago

HI @mbedNoobNinja

Sorry for keep you waiting. I am out of the office for a national holiday. Can you go ahead your work by referring to this(#5628 & the current state of VK_RZ_A1H) until I PR?

TomoYamanaka commented 6 years ago

Hi @mbedNoobNinja

Thank you for waiting. I did PR the registration of GR-LYCHEE target and the new folder structiures to share common codes(#5813). Could you PR the update of VK_RZ_A1H related after my PR merged?

mbedNoobNinja commented 6 years ago

I will, after the (#5813) is merged, but my PR concerning the VK_RZ_A1H, may come a bit later. (with a delay of week or two, after the merging)

TomoYamanaka commented 6 years ago

I look forward to your PR.

mbedNoobNinja commented 6 years ago

Hi colleagues. Do you have any idea why these paths:

\mbed-os\targets\TARGET_RENESAS
\mbed-os\targets\TARGET_RENESAS\TARGET_RZ_A1XX
\mbed-os\targets\TARGET_RENESAS\TARGET_RZ_A1XX\common
\mbed-os\targets\TARGET_RENESAS\TARGET_RZ_A1XX\TARGET_VK_RZ_A1H
\mbed-os\targets\TARGET_RENESAS\TARGET_RZ_A1XX\TARGET_VK_RZ_A1H\device
\mbed-os\targets\TARGET_RENESAS\TARGET_RZ_A1XX\TARGET_VK_RZ_A1H\device\inc
\mbed-os\targets\TARGET_RENESAS\TARGET_RZ_A1XX\TARGET_VK_RZ_A1H\device\inc\iobitmasks
\mbed-os\targets\TARGET_RENESAS\TARGET_RZ_A1XX\TARGET_VK_RZ_A1H\device\inc\iodefines
\mbed-os\targets\TARGET_RENESAS\TARGET_RZ_A1XX\TARGET_VK_RZ_A1H\device\TOOLCHAIN_ARM_STD

are not included in .includes_md5 when compiling anything for VK_RZ_A1H?

TomoYamanaka commented 6 years ago

@mbedNoobNinja I do not know well, but are there missing configurations in targets.json?

mbedNoobNinja commented 6 years ago

I tried. The board was temporrary disabled by this "release_versions": [], so I changed that to "release_versions": ["2", "5"]. But then the CLI complained [Error] irq_ctrl_gic.c@27,0: #5: cannot open source input file "cmsis.h": No such file or directory, because cmsis.h is in one of the missing paths above. I didn't find any suspicuous cause in scripts in tools/toolchain's, responsible for constructing the .include_md5. Otherwise, the update is ready and everythings looks fine when compiled through the DS5 IDE (the blinky project works !). I have to launch the tests to be shure, but they use CLI, so I don't know where to look further.

0xc0170 commented 6 years ago

@mbedNoobNinja Can you provide your branch that we could reproduce the issue?

mbedNoobNinja commented 6 years ago

Ok. Here it is: https://github.com/mbedNoobNinja/mbed/tree/CLI_issue

0xc0170 commented 6 years ago

@mbedNoobNinja that helped, the issue is with extra_labels, you are overwritting labels, not adding them . Use extra_labels_add that will fix the problem you are seeing

I am currently compiling your platform, seems to be going OK

mbedNoobNinja commented 6 years ago

Thank you @0xc0170, I will PR the changes along with the test results.

mbedNoobNinja commented 6 years ago

Yeah, there it is #6245 ... finally ! @TomoYamanaka, @0xc0170 thank you for the waiting. One RTSP client delayed me ... It turned out getting MJPEG stream from Ethernet & playing on MBED board, is not so easy, as I expected. By the way, Have you met a decent RTSP client for MBED (with the whole glory of RTCP and more specifically senders and receivers reports) or something close that should do the job ?

TomoYamanaka commented 6 years ago

@0xc0170 Could you close this issue because this was updated by #6245 ?