Closed ccli8 closed 5 years ago
0xc0170
commented
6 years ago I can not reproduce. I added lines
"NUMAKER_PFM_NUC472_NOXRAM": {
"inherits": ["NUMAKER_PFM_NUC472"],
"extra_labels_remove": ["NU_XRAM_SUPPORTED"],
"extra_labels_add": ["NU_XRAM_UNSUPPORTED"]
},after NUMAKER_PFM_NUC472 and mbed test does compile for me. Even if I do only mbed test -m NUMAKER_PFM_NUC472_NOXRAM -t GCC_ARM --list, it prints available tests.
ciarmcom
commented
6 years ago ARM Internal Ref: MBOTRIAGE-225
cmonr
commented
6 years ago @ccli8 Could you answer @0xc0170 request for a reproduction of the issue? If not, this issue will be closed soon.
theotherjimmy
commented
6 years ago @ccli8 You can't add targets in mbed_app.json please use custom_targets.json instead.
theotherjimmy
commented
6 years ago @ccli8 For the second, greatea error, you need to tell mbedls how to identify the target correctly, and the target must be plugged in. You will have to use mbedls's mock functionality, https://github.com/ARMmbed/mbed-ls#mocking-renaming-platforms
ccli8
commented
6 years ago @ccli8 Could you answer @0xc0170 request for a reproduction of the issue? If not, this issue will be closed soon.
@0xc0170 @cmonr Sorry, I miss it.
@theotherjimmy Checking on last mbed-os e8ec3614b0a2573b397c709b6a40e66e3c0c830f, I try custom_targets.json but fail:
custom_targets.json:
{
"NUMAKER_PFM_NUC472_NOXRAM": {
"inherits": ["NUMAKER_PFM_NUC472"],
"extra_labels_remove": ["NU_XRAM_SUPPORTED"],
"extra_labels_add": ["NU_XRAM_UNSUPPORTED"]
}
}Run Greentea test:
mbed test -m NUMAKER_PFM_NUC472_NOXRAM -t ARM -n mbed-os-tests-mbedmicro-mbed-cppBut fail with:
$ mbed test -m NUMAKER_PFM_NUC472_NOXRAM -t ARM -n mbed-os-tests-mbedmicro-mbed-cpp
Scan: .
Scan: TESTS
Scan: TESTS
Scan: TESTS
Scan: TESTS
Scan: TESTS
Scan: TESTS
Scan: TESTS
Scan: TESTS
Building library mbed-build (NUMAKER_PFM_NUC472_NOXRAM, ARM)
Scan: nu-greentea
Scan: ARM
Traceback (most recent call last):
File "C:\ccli8\iot\mbed\mbed-os\nu-greentea\mbed-os\tools\test_api.py", line 2195, in build_test_worker
bin_file = build_project(*args, **kwargs)
File "C:\ccli8\iot\mbed\mbed-os\nu-greentea\mbed-os\tools\build_api.py", line 554, in build_project
app_config=app_config, build_profile=build_profile, ignore=ignore)
File "C:\ccli8\iot\mbed\mbed-os\nu-greentea\mbed-os\tools\build_api.py", line 328, in prepare_toolchain
config = config or Config(target, src_paths, app_config=app_config)
File "C:\ccli8\iot\mbed\mbed-os\nu-greentea\mbed-os\tools\config\__init__.py", line 477, in __init__
self.app_config_data.get("custom_targets", {}), tgt)
File "C:\ccli8\iot\mbed\mbed-os\nu-greentea\mbed-os\tools\targets\__init__.py", line 122, in generate_py_target
return target(name, total_data)
File "C:\ccli8\iot\mbed\mbed-os\nu-greentea\mbed-os\tools\targets\__init__.py", line 101, in target
resolution_order = get_resolution_order(json_data, name, [])
File "C:\ccli8\iot\mbed\mbed-os\nu-greentea\mbed-os\tools\targets\__init__.py", line 93, in get_resolution_order
parents = json_data[target_name].get("inherits", [])
KeyError: u'NUMAKER_PFM_NUC472_NOXRAM'
Traceback (most recent call last):
File "C:\ccli8\iot\mbed\mbed-os\nu-greentea\mbed-os\tools\test.py", line 247, in <module>
ignore=options.ignore)
File "C:\ccli8\iot\mbed\mbed-os\nu-greentea\mbed-os\tools\test_api.py", line 2302, in build_tests
report_entry[worker_result['kwargs']['project_id'].upper()][0][0]['output'] = new_notify.get_output()
KeyError: 'MBED-OS-TESTS-MBEDMICRO-MBED-CPP'
[ERROR] 'MBED-OS-TESTS-MBEDMICRO-MBED-CPP'
[mbed] ERROR: "c:\python27\python.exe" returned error code 1.
[mbed] ERROR: Command "c:\python27\python.exe -u C:\ccli8\iot\mbed\mbed-os\nu-greentea\mbed-os\tools\test.py -t ARM -m NUMAKER_PFM_NUC472_NOXRAM --source C:\ccli8\iot\mbed\mbed-os\nu-greentea --build C:\ccli8\iot\mbed\mbed-os\nu-greentea\BUILD\tests\NUMAKER_PFM_NUC472_NOXRAM\ARM --test-spec C:\ccli8\iot\mbed\mbed-os\nu-greentea\BUILD\tests\NUMAKER_PFM_NUC472_NOXRAM\ARM\test_spec.json -n mbed-os-tests-mbedmicro-mbed-cpp" in "C:\ccli8\iot\mbed\mbed-os\nu-greentea"
---It looks like you did not build a test there. Could you check that? If you don't build a test, you may run into that trace back.
ccli8
commented
6 years ago @theotherjimmy Yes, the test is not built. But I expect the test would be automatically built even though I run test on custom target:
mbed test -m NUMAKER_PFM_NUC472_NOXRAM -t ARM -n mbed-os-tests-mbedmicro-mbed-cpp
Compared to above, if I run test on native target, it is OK.
mbed test -m NUMAKER_PFM_NUC472 -t ARM -n mbed-os-tests-mbedmicro-mbed-cpp
theotherjimmy
commented
6 years ago @ccli8 I can't reproduce this with the latest master.
mattbrown015
commented
6 years ago @theotherjimmy I wonder if you can help me? I came to this issue because I was getting the KeyErr when I tried to build for a custom target. I started trying understand TESTS but have now got completely lost.
I added TESTS\group\case\main.cpp to our project. main.cpp only contains 3 lines, int main() {}!
Initially I tried to specify our custom target and got the KeyError so I just changed to specifying NUCLEO_L433RC_P.
I just did this from the project directory:
`mbed test --compile -m NUCLEO_L433RC_P -n tests-group-case`but this fails because of linker errors. mbed test is building the project root and finding the application's main.
Is testing supposed to work for applications or can it only be used for libs?
I've been staring at Testing Applications but quite clearly I'm missing something! Perhaps I'm having a Friday afternoon moment. Thanks.
mbed --version 1.7.3 mbed-os is 5bf483e
theotherjimmy
commented
6 years ago @mattbrown015 I was able to add the following custom_targets.json and compile tests successfully:
{
"MY_TARGET": {
"inherits": ["NUCLEO_F411RE"]
}
}I cannot reproduce the KeyError you are seeing.
WRT the duplicate main function, yes that's a know issues with placing tests in the same project as an application.
mattbrown015
commented
6 years ago @theotherjimmy Hhhmm, that's odd my custom target looks exactly like yours except I inherit from NUCLEO_L432KC. Could it be target specific? Could it be tool version specific?
But, it's a bit academic if I can't create tests for an application. Any thoughts about work arounds? Use a macro defined as main for the normal build and a second config that defines it has not_main for the test build?? Somewhat cryptic! I might try on Monday.
theotherjimmy
commented
6 years ago That'll probably work for you.
theotherjimmy
commented
6 years ago Make sure that you spelled the target correctly in the inherits, and that it's a list. Those may cause keyerrors.
mattbrown015
commented
6 years ago @theotherjimmy I copied your custom_targets.json from above, still no joy.
The error I see is almost exactly what @ccli8 has posted above so I haven't bothered posting it again.
AFAICT, I'm using a different mbed-cli and repo version to @ccli8. So no clues there.
I'm building an app so I have a mbed_app.json rather than an mbed_lib.json. Could it be anything to do with that?
My only other thoughts was that I using Windows.
mattbrown015
commented
6 years ago @theotherjimmy As regards the possibly more important issue of creating a test framework for an application I've decided it's more complicated that just having multiple definitions of main.
Any statically allocated objects from the application code will also be crated and initialised and that's not really what I want.
I was hoping to use the test framework to create some small tests to test, in isolation, some small parts of our application.
It's quite possible that was I thinking of doing doesn't really make any sense. I shall think about it in the background!
theotherjimmy
commented
6 years ago @ccli8 I used:
commit e8ec3614b0a2573b397c709b6a40e66e3c0c830f
Merge: 95d2b3d55 8efe3b5bc
Author: Cruz Monrreal <Cruz.Monrreal@arm.com>
Date: Thu Jun 21 18:23:07 2018 -0500
Merge pull request #7291 from aqib-ublox/master
adding USTICKER label for C027
, the exact commit you mentioned in your second comment. I also used the custom_targets.json from my comment. I compiled with mbed test --compile -t arm -m MY_TARGET, and I could not reproduce the problem you reported. You might have stale .pyc files. You could try running git clean -xf in your mbed-os dir.
mattbrown015
commented
6 years ago I did git clean -xf but it didn't make any difference. It's a mystery!
git clean -xf is a good tip though, I might do it more often in future. :-)
mattbrown015
commented
6 years ago Just seen Tests not possible with costum target #7395 which seems to be discussing the problem with custom targets.
ccli8
commented
6 years ago @theotherjimmy I still meet the error even though I clean up *.pyc files with git clean -xf.
EmbedEngineer
commented
6 years ago @theotherjimmy As @mattbrown015 mentioned, I stumbled upon the same problem, that I cannot compile any test if I use a custom defined target. Please have a look at my issue report #7395.
I my opinion it is independend from the mbed cli version and just is a bug in the mbed os tools.
EmbedEngineer
commented
6 years ago For tracking: my custom_targets.json looks like this:
{
"MY_TARGET": {
"inherits": [
"EFM32PG12B500F1024GL125"
],
"device_has": [
"ANALOGIN",
"I2C",
"I2CSLAVE",
"I2C_ASYNCH",
"INTERRUPTIN",
"LPTICKER",
"PORTIN",
"PORTINOUT",
"PORTOUT",
"PWMOUT",
"RTC",
"SERIAL",
"SERIAL_ASYNCH",
"SLEEP",
"SPI",
"SPISLAVE",
"SPI_ASYNCH",
"STDIO_MESSAGES",
"USTICKER",
"TRNG",
"FLASH"
],
"forced_reset_timeout": 2,
"OUTPUT_EXT": "hex",
"config": {
"hf_clock_src": {
"help": "Value: HFXO for external crystal, HFRCO for internal RC oscillator",
"value": "HFXO",
"macro_name": "CORE_CLOCK_SOURCE"
},
"hfxo_clock_freq": {
"help": "Value: External crystal frequency in hertz",
"value": "40000000",
"macro_name": "HFXO_FREQUENCY"
},
"lf_clock_src": {
"help": "Value: LFXO for external crystal, LFRCO for internal RC oscillator, ULFRCO for internal 1KHz RC oscillator",
"value": "LFXO",
"macro_name": "LOW_ENERGY_CLOCK_SOURCE"
},
"lfxo_clock_freq": {
"help": "Value: External crystal frequency in hertz",
"value": "32768",
"macro_name": "LFXO_FREQUENCY"
},
"hfrco_clock_freq": {
"help": "Value: Frequency in hertz, must correspond to setting of hfrco_band_select",
"value": "38000000",
"macro_name": "HFRCO_FREQUENCY"
},
"hfrco_band_select": {
"help": "Value: One of cmuHFRCOFreq_1M0Hz, cmuHFRCOFreq_2M0Hz, cmuHFRCOFreq_4M0Hz, cmuHFRCOFreq_7M0Hz, cmuHFRCOFreq_13M0Hz, cmuHFRCOFreq_16M0Hz, cmuHFRCOFreq_19M0Hz, cmuHFRCOFreq_26M0Hz, cmuHFRCOFreq_32M0Hz, cmuHFRCOFreq_38M0Hz. Be sure to set hfrco_clock_freq accordingly!",
"value": "cmuHFRCOFreq_38M0Hz",
"macro_name": "HFRCO_FREQUENCY_ENUM"
},
"board_controller_enable": {
"help": "Pin to pull high for enabling the USB serial port",
"value": "PA5",
"macro_name": "EFM_BC_EN"
}
},
"target_overrides": {
"events.use-lowpower-timer-ticker": 1
}
}
}I basically just did the the custom_target because we want to have our own pinnames.h and use a different clock. I knwo we could have just done the same thing in the mbed_app.json, but since we will have multiple versions of this boards, this would fit our needs much better. The standard EFM32PG12_STK3402 devBoard is mocked in mbed ls with MY_TARGET. The normal build with mbed compile works fine, flashing is also working. The only thing which is not working is compiling the tests with mbed test.
theotherjimmy
commented
6 years ago "target_overrides": { "events.use-lowpower-timer-ticker": 1 }This won't work.
theotherjimmy
commented
6 years ago @EmbedEngineer on current master, with your custom_targets.json I get:
Compile [ 0.2%]: mbed_tz_context.c
Compile [ 0.3%]: BusInOut.cpp
[Error] objects.h@27,0: #5: cannot open source input file "PinNames.h": No such file or directory
Failed to build libraryWhich indicates that I'm at the step where I would need parts of your board port.
EmbedEngineer
commented
6 years ago @theotherjimmy Sure thank you for trying it out.
My PinNames.h is:
#ifndef MBED_PINNAMES_H
#define MBED_PINNAMES_H
#include "CommonPinNames.h"
#ifdef __cplusplus
extern "C"
{
#endif
typedef enum
{
EFM32_STANDARD_PIN_DEFINITIONS,
LED0 = PF4,
LED1 = PF5,
/* Serial (just some usable pins) */
SERIAL_TX = PA6,
SERIAL_RX = PA7,
/* Board Controller UART (USB)*/
USBTX = PA0,
USBRX = PA1,
/* Board Controller */
STDIO_UART_TX = USBTX,
STDIO_UART_RX = USBRX
} PinName;
#ifdef __cplusplus
}
#endif
#endifFurthermore you will need a device_peripherals.h:
#ifndef MBED_DEVICE_PERIPHERALS_H
#define MBED_DEVICE_PERIPHERALS_H
/* us ticker */
#define US_TICKER_TIMER TIMER0
#define US_TICKER_TIMER_CLOCK cmuClock_TIMER0
#define US_TICKER_TIMER_IRQ TIMER0_IRQn
/* PWM */
#define PWM_TIMER TIMER1
#define PWM_TIMER_CLOCK cmuClock_TIMER1
#define PWM_ROUTE TIMER_ROUTE_LOCATION_LOC1
/* Crystal calibration */
#if !defined(CMU_HFXOINIT_STK_DEFAULT)
#define CMU_HFXOINIT_STK_DEFAULT \
{ \
true, /* Low-power mode for EFM32 */ \
false, /* Disable auto-start on EM0/1 entry */ \
false, /* Disable auto-select on EM0/1 entry */ \
false, /* Disable auto-start and select on RAC wakeup */ \
_CMU_HFXOSTARTUPCTRL_CTUNE_DEFAULT, \
0x142, /* Steady-state CTUNE for STK boards without load caps */ \
_CMU_HFXOSTEADYSTATECTRL_REGISH_DEFAULT, \
0x20, /* Matching errata fix in CHIP_Init() */ \
0x7, /* Recommended steady-state osc core bias current */ \
0x6, /* Recommended peak detection threshold */ \
_CMU_HFXOTIMEOUTCTRL_SHUNTOPTTIMEOUT_DEFAULT, \
0xA, /* Recommended peak detection timeout */ \
0x4, /* Recommended steady timeout */ \
_CMU_HFXOTIMEOUTCTRL_STARTUPTIMEOUT_DEFAULT, \
cmuOscMode_Crystal, \
}
#endif
/* DCDC settings */
#if !defined(EMU_DCDCINIT_STK_DEFAULT)
#define EMU_DCDCINIT_STK_DEFAULT EMU_DCDCINIT_DEFAULT
#endif
#endifI put both files in a TARGET_MY_TARGET folder.
theotherjimmy
commented
6 years ago @EmbedEngineer I was able to compile mbed and tests with those headers. I cannot reproduce your issue.
Maybe you're placing custom_targets.json in the wrong location? Where have you put it in your project? does mbed compile -m MY_TARGET work?
EmbedEngineer
commented
6 years ago @theotherjimmy I put the custom_targets.json in the root directory (my workspace folder where I start mbed compile).
mbed compile -m MY_TARGET works just fine. Maybe it is a problem because I am using the arm gcc compiler as I am suspecting in my issue #7395?
theotherjimmy
commented
6 years ago For good measure, I ran it with gcc_arm as well, and it works just fine for me.
aashishc1988
commented
5 years ago The PR, https://github.com/ARMmbed/mbed-os/pull/7477, addresses the problem listed here, and on https://github.com/ARMmbed/mbed-os/issues/7395. Before that PR, i was able to reproduce the behavior as indicated by @ccli8 , and @EmbedEngineer, but not anymore.
@ccli8 , please update your workspace to include those changes and try again. Let me know if you still the issue.
ccli8
commented
5 years ago @aashishc1988 I test on mbed-os-5.9.3 and master (63f62165d89f5562c529cd3ecb94823ce1dc7f13). The issue gets resolved on them.
Description
Enhancement
Target NUMAKER_PFM_NUC472
Toolchain: ARM
mbed-cli version: 1.4.0
python 2.7.1
mbed-os sha: f67fe4a Merge pull request #6257 from SenRamakri/sen_FaultHandlerFixes
If I run on original target NUMAKER_PFM_NUC472:
Everything goes fine.
If I add target NUMAKER_PFM_NUC472_NOXRAM inheriting NUMAKER_PFM_NUC472 in
mbed_app.json:And run:
I get error:
If I add target NUMAKER_PFM_NUC472_NOXRAM inheriting NUMAKER_PFM_NUC472 in
mbed-os/targets/targets.json:And run:
I get error: