search

ARMmbed / mbed-semtech-lora-rf-drivers

Semtech's LoRa RF drivers for mbed OS
Other
31 stars 25 forks source link

Remove product specific variables and target flags #15

Closed kivaisan closed 6 years ago

kivaisan commented 6 years ago

Since variant detection is using ant_switch pin, it is now only used if that pin has been connected. Otherwise generic variant code is used.

kivaisan commented 6 years ago

This also addresses issue #13 .

hasnainvirk commented 6 years ago

@kivaisan we can generally accept this PR. My concern is that there can be another variant based on SX127X which may not have an ant_switch and a PA. In that case why would we enforce PA boost ? What do you think ?

kivaisan commented 6 years ago

Yes, but at the moment all our radios use PABOOST. The problem is that we don't know what kind of HWs there will be. So I think this is ok for now and let's change if needed.