Rename file ble.h into nrf_ble.h.

ARMmbed / nrf51-sdk

Module to contain files provided by the nordic nRF51 SDK

Other

13 stars 17 forks source link

Rename file ble.h into nrf_ble.h. #26

Closed pan- closed 8 years ago

pan- commented 8 years ago

This change will mitigate issues when nrf51-sdk is compiled on mbed-classic.

ciarmcom commented 8 years ago

Automatic CI verification build not done, please verify manually.

pan- commented 8 years ago

@rgrover @LiyouZhou Could you review this please ?

rgrover commented 8 years ago

looks OK except for the white-space diffs which are avoidable.

LiyouZhou commented 8 years ago

I think whitespace changes should not be rolled together into the same PR. Ideally we want to keep changes to nordic file to a minimum, hence no whitespace changes but I don't know to what extend it is true in this repo.

pan- commented 8 years ago

Thanks everyone,

Will change my editor settings and redo the commit.

pan- commented 8 years ago

@LiyouZhou Hope it is better, let me know.

LiyouZhou commented 8 years ago

Look good.