Closed LiyouZhou closed 8 years ago
@LiyouZhou please confirm that the bootloader is still able to build and work correctly with this new SDK. I have a feeling you'll find that the bootloader doesn't work any more unless you fix the constants in hci_mem_pool_internal.h
(see comments above).
Jonny is currently attempting to build the bootloader for BBC. Please connect with him to align with his efforts.
Please also ensure that the memory consumption doesn't go up with this new SDK. Building any of our examples should show the heap sizes at the end. This is important.
I would like you to discuss your approach with others members of the team. Please document the affects of switching to the new SDK; we need to ensure that we don't affect existing functionality--such as use of pstorage
, bootloader
, etc. Could you also please highlight the important parts of the release notes for SDKv9?
@LiyouZhou please also be mindful that we need to hand-apply the changes from SDKv9 to the ble-nrf51822 repository on mbed.org. That repository will no longer automatically sync with the changes to the SDK.
@rgrover pstorage cmd queue size reduced to 2 in new commit. Mem usage increased by 24bytes as a result of updating the sdk. Bootloader continue to work.
@LiyouZhou you claim: Mem usage increased by 24bytes as a result of updating the sdk.
Can you account for this?
@rgrover by looking at the obj-dump the major refactorying of pstorage.c caused this increase. There is a lot of change, hence it is difficult to tell exactly what cause memory increase.
@LiyouZhou ok. Thanks for this dive. 24bytes isn't too much to worry about.
@rgrover hold off merging, need to talk to jonny and make a small change.
sdk10 has a fix for "App_pwm occasionally gives inverted signal"
@jrobeson I'm currently in the process of upgrading to v10. Should be up shortly.
Tests:
clitest - all expected passes pass, all expected fails fail. build - all ble-examples build successfully pstorage - tested against https://github.com/andresag01/ble-examples-1/tree/eddystone_pstorage and works dfu - tested to work
Highlight from sdk 9 release notes:
Changes
Fixed issues:
Known issues:
@ARMmbed/ble-owners Please review.