ARMmbed / qspif-blockdevice

DEPRECATED: This repository is deprecated, please use mbed-os-example-blockdevice
5 stars 2 forks source link

QSPI SFDP Flash - Block Device #1

Closed offirko closed 6 years ago

offirko commented 6 years ago

Hello: @bulislaw , @donatieng , @ARMmbed/mbed-os-maintainers , @dannybenor , @davidsaada . I'd appreciate your review of QSPIF Block Device

offirko commented 6 years ago

@maciejbocianski you're review is welcome

maciejbocianski commented 6 years ago

@offirko Are we going to have API for QSPI read/write mode configuration (1-1-1/1-2-2/...)? What will allow to choose what read/write speed/width we want to use

list<mode> get_supported_write_modes() from SFDP
list<mode> get_supported_read_modes() from SFDP
bool set_write_mode(mode)
bool set_read_mode(mode)
offirko commented 6 years ago

@maciejbocianski

Are we going to have API for QSPI read/write mode configuration (1-1-1/1-2-2/...)?

According to the design we decided not to add this flexibility. An internal logic selects the "fastest" mode from the supported ones (as described in SFDP Tables) See Section 3.5 at the design doc link: https://armh.sharepoint.com/:w:/r/sites/IoT-Project-Morpheus/Shared%20Documents/design-docs/QSPI%20Block%20Device%201.0.1.docx?d=w70bb086fb2be4d0e92c62a42040197dc&csf=1&e=2UlrqT

offirko commented 6 years ago

@0xc0170 , @donatieng , @davidsaada

I related to your comments and pushed changes related to them. Please re-review - thanks.

offirko commented 6 years ago

@0xc0170 - I added the changes related to your comments, please review - thanks.

geky commented 6 years ago

Out of curiousity, how much code size does the library cost?

offirko commented 6 years ago

@geky , Thanks for your remarks! Code size is 5Kbyte compiled with GCC_ARM