search

ARMmbed / qspif-blockdevice

DEPRECATED: This repository is deprecated, please use mbed-os-example-blockdevice
5 stars 2 forks source link

Fix for DISCO_L475VG_IOT01A #18

Closed deepikabhavnani closed 6 years ago

deepikabhavnani commented 6 years ago

Fix for https://github.com/ARMmbed/qspif-blockdevice/issues/15

Dependent on : https://github.com/ARMmbed/qspif-blockdevice/pull/17

Commits for this PR: https://github.com/ARMmbed/qspif-blockdevice/commit/06e2df0e410c19c8d557a60f37b5657fac15e129 https://github.com/ARMmbed/qspif-blockdevice/commit/534cdee5d6de0674cb53f07450dce2190a79a872

deepikabhavnani commented 6 years ago

CC @geky

deepikabhavnani commented 6 years ago

@geky @offirko - Please review. Fix for DISCO_L475VG_IOT01A is required for connect+update working.

offirko commented 6 years ago

@deepikabhavnani - Thanks for the fix! I added a few comments and questions.

deepikabhavnani commented 6 years ago

@offirko - I have addressed the review comments.

offirko commented 6 years ago

@deepikabhavnani - looks great to me, thanks!

deepikabhavnani commented 6 years ago

@offirko - Is something pending from my side to get this merged?

offirko commented 6 years ago

@deepikabhavnani - nothing is pending, I completed the merge now - thanks.