search

ARMmbed / sal

mbed C abstract socket API layer
Other
3 stars 16 forks source link

Import four inet_address functions from #17

Closed bremoran closed 8 years ago

bremoran commented 9 years ago

Add support for converting inet addresses to strings and vice versa

bremoran commented 9 years ago

Note: These functions still need to be integrated with our APIs; this is an import only

bremoran commented 8 years ago

@bogdanm @niklas-arm @0xc0170

0xc0170 commented 8 years ago

Shall also license files be updated, as I see there's apache at the moment in this module ?

bogdanm commented 8 years ago

Shall also license files be updated, as I see there's apache at the moment in this module ?

+1. Ideally, the origin of the files should also be stated somewhere, in case someone ever needs to get a newer version of these files from their original project (if this is an option). That said, why are we adding .nocompile files ? Seems a bit weird. Isn't it better to wait until we have something that actually works and compiles?

bremoran commented 8 years ago

I'll get the license files included.

You're right, @bogdanm they shouldn't have the .nocompile. The reason for that is that these files cannot be used unmodified. They depend on some header files we don't have and they also require some structures that we don't have. The changes are small, but they do require modification.

bremoran commented 8 years ago

I suggest reviewing each patch in isolation, otherwise this is unmanageable.

autopulated commented 8 years ago

For future reference you can use .yotta_ignore instead of renaming things to .nocompile :smile:

niklarm commented 8 years ago

+1.