search

ARMmbed / sal

mbed C abstract socket API layer
Other
3 stars 16 forks source link

Switch to config dependency. #20

Closed bremoran closed 9 years ago

bremoran commented 9 years ago

Also update sal-stack-lwip dependency

cc @bogdanm

miklis commented 9 years ago

Build finished. No test results found.

bogdanm commented 9 years ago

Looks good, but I just realized that it exhibits the same issue with incompatible targets as the pin config stuff. If an older version of (say) mbed-example-network needs to be compiled and uses the new target definition, won't it fail? (not a problem with this change in particular, but more with the whole idea of "incompatible targets")

bremoran commented 9 years ago

@bogdanm In this case, this will be a minor version bump anyway, so it should be fine; the new version of the target has already been published. More important is that the target still defines lwip in the similar-to field, so the new target works with older modules.

bogdanm commented 9 years ago

Great, that'll work then. +1.