Addressed git issues: #42, #45 and partially #48.

ARMmbed / sockets

mbed sockets library abstraction layer

Other

6 stars 18 forks source link

Addressed git issues: #42, #45 and partially #48. #49

Closed adbridge closed 8 years ago

adbridge commented 8 years ago

Updates to methods documentation and error checking fixes.

@bremoran please review and merge if happy.

bremoran commented 8 years ago

One general comment: when enumerating return values, use @retval. https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdretval

bremoran commented 8 years ago

bump @adbridge

bremoran commented 8 years ago

It's consistent elsewhere in the API that a call with a NULL generates a SOCKET_ERROR_NULL_PTR. SOCKET_ERROR_BAD_ADDRESS is otherwise reserved for formatting errors. Please see here:

https://github.com/ARMmbed/sal/blob/master/source/socket_abstract.c#L59

adbridge commented 8 years ago

@bremoran Review comments actioned please double check and merge

bremoran commented 8 years ago

@adbridge If this means that #42 #45 and #48 can be closed, please do so.