search

ARMmbed / sockets

mbed sockets library abstraction layer
Other
6 stars 18 forks source link

TCPStream issues #54

Open adbridge opened 8 years ago

adbridge commented 8 years ago

  1. When instantiating the class using the constructor: TCPStream(const socket_stack_t stack);

    there is no guarantee of a valid api being set. Thus if the connect method is then used, _socket.api
    could be NULL. Should check this within the connect method. If this is added then the method header should be updated accordingly.

  2. Similarly for the setNagle() method. _socket.api could be invoked with a NULL value. Also setNagle calls set_option() which returns an error type which is then ignored. Shouldn't this error type be forwarded up to the caller of the method?
ciarmcom commented 8 years ago

ARM Internal Ref: IOTSFW-1616

adbridge commented 8 years ago

@bremoran bump. Point 2 above still needs commenting / a decision made on