search

ARMmbed / target-kinetis-k64-gcc

base yotta target description for compiling for the Freescale Kinetis K64 chip family using gcc
Apache License 2.0
1 stars 4 forks source link

[IOTSFW-2509] Fix for broken yotta and jenkins builds #6

Closed hasnainvirk closed 8 years ago

hasnainvirk commented 8 years ago

This PR will fix the broken yotta and jenkins builds with uvisor

@bogdanm @AlessandroA

teetak01 commented 8 years ago

+1, at least fixed issues on mbed Client side

bogdanm commented 8 years ago

@AlessandroA, can you please take a look at this?

hasnainvirk commented 8 years ago

@kjbracey-arm , @AlessandroA , @bogdanm

kjbracey commented 8 years ago

We've created a second attempt at this. Have another look.

bogdanm commented 8 years ago

Looks much better now, but I'd really like @AlessandroA to look it at (or maybe @meriac if Alessandro is not available).

kjbracey commented 8 years ago

I'd like to double-check what the 512 byte reservation is (was?) for, and document it.

Note that there is now a detailed commit message explaining what's happening - GitHub doesn't seem to make this obvious.

teetak01 commented 8 years ago

+1 this also works for Client

ghost commented 8 years ago

The description says Ram contains uvisor.bss followed by stack, but the script itself only appears to place the stack in RAM, everything else goes to RAM2. Is the description wrong or have I mis-read the script?

kjbracey commented 8 years ago

Lines 59-80, untouched by this commit, are putting uvisor.bss in RAM.

meriac commented 8 years ago

++, LGTM @mjs-arm @hasnainvirk

bogdanm commented 8 years ago

Thanks a lot @meriac!