search

ARMmbed / target-mbed-gcc

DEPRECATED Base for mbed yotta compilation targets compiling with GCC
Apache License 2.0
6 stars 12 forks source link

remove CMakeForceCompiler #18

Closed bachp closed 8 years ago

bachp commented 8 years ago

It is deprecated, CMake is now able to detect the GCC/GNU toolchain on it's own.

ghost commented 8 years ago

isn't it too soon to do this?

bachp commented 8 years ago

What versions of CMake are required to be supported?

As far as I know this would only be required for CMake 2.6.x. There are already better ways of defining toolchains even of the CMakeForceCompiler modules was deprecated onyl ]recently](https://github.com/Kitware/CMake/commit/ed77504d89f99c1a395b5472f51d181ad25b90c0).

ghost commented 8 years ago

so you haven't needed CmakeForceCompiler since 2.6? news to me, but I guess I'm no CMake expert.

bachp commented 8 years ago

I could be wrong but I think at least for the GNU compilers this should work with the CMake versions that are most common out there.

bachp commented 8 years ago

Up until now I tested this with frdm-k64f-gcc and CMake 2.8.12.2 and that workes without issue.

bachp commented 8 years ago

Well maybe it's really to early. I ran into some issues with atmel-samr21g18a-gcc. I'm not sure it's because the target is not ready yet or because of my change. I will close the pull request for the moment.