search

ARMmbed / wifi-ism43362

ISM43362 WiFi driver
17 stars 22 forks source link

ATParser.cpp: incompatible redefinition of macro MIN #24

Closed teetak01 closed 2 years ago

teetak01 commented 6 years ago

Description

Mbed OS 5.9.1 Component: ARM Compiler 5.06 update 3 (build 300)

ATParser.cpp@37,0:  #47-D: incompatible redefinition of macro "MIN" (declared at line 145 of "./mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/drivers/fsl_common.h")

[ ] Question
[ ] Enhancement
[X] Bug

This driver is still using its own ATParser.cpp. Would it make sense to use the Mbed OS implementation instead and remove this component?

For. ESP8266 removed the dependency here: https://github.com/ARMmbed/esp8266-driver/pull/46

teetak01 commented 6 years ago

Originally reported here: https://github.com/ARMmbed/mbed-os/issues/7256

0xc0170 commented 5 years ago

@jeromecoutant Is this still an issue? Shall be closed or fixed?

jeromecoutant commented 5 years ago

About MIN macro redefinition, to be honest, I don't know

About using AT parser from mbed-os, this is still in my long todo list :-)