search

ARMmbed / yotta

DEPRECATED: yotta build; better software
Apache License 2.0
164 stars 64 forks source link

Semver incompatibility #803

Closed jamesadevine closed 7 years ago

jamesadevine commented 7 years ago

Hi,

It seems the recent version has broken semantic version for any previous version, which we heavily use in our project, microbit-dal.

We have had two new users on v18 who have reported this breakage: https://github.com/lancaster-university/microbit-dal/issues/282

Any help would be greatly appreciated :smile:

thegecko commented 7 years ago

Hi @jamesadevine I don't think this is semver version issue, but a problem with the + characters in the tag names being used.

The method and regex's used to correctly support github URLs was changed in the recent release.

A fix would likely require a modification to the regex to add a + here:

https://github.com/ARMmbed/yotta/blob/master/yotta/lib/sourceparse.py#L60

jamesadevine commented 7 years ago

@thegecko Thanks for the amazingly swift response and solution :smile:

thegecko commented 7 years ago

nps