Closed bogdanm closed 7 years ago
@thegecko @marcuschangarm
I don't know what to make of the circleci error, I don't understand what's causing it.
I think the gecko mentioned that the circle job doesn't work...
@bogdanm I plan to fix Circle sometime soon, for now Travis is good enough to know we are all good :)
kudos for the tests
The circle job runs tests which Travis can't, it's configured with credentials for a dummy github account etc.. It also runs a linter. It looks like the failure is because the linter is failing:
py34 runtests: commands[2] | pylint ./yotta
************* Module yotta.link_target
C: 16, 0: Trailing whitespace (trailing-whitespace)
It also runs a linter. It looks like the failure is because the linter is failing:
Yes, but I can't make sense of the output:
Global evaluation
-----------------
Your code has been rated at 10.00/10
ERROR: InvocationError: '/home/ubuntu/yotta/.tox/py27/bin/pylint ./yotta'
So pylint obviously ran, it gave a score of 10/10, yet I'm still getting an InvocationError. I don't understand why. Maybe pylint can give 10/10 but still fail?
see the error quoted above – think the 10/10 score is rounded up from 9.999/10, but if there are any errors the exit status is non-zero.
The actual error is trailing space at the end of line 16 in yotta/link_target.py
I have fixed the circle build, thanks to @autopulated !
@bogdanm This PR looks good, should we add a version bump, too?
I think a new minor is advisable, yes. Thanks @autopulated for all the help.
Great, can you rebase and bump the version? Should get all tests passing ;)
:confetti_ball:
This commit adds the ability to use modules that have sources defined in their top level directory, both directly and in various subdirectories:
This works both for libraries and applications by specifying
"lib": "."
or"bin": "."
respectively in theirmodule.json
.The current implementation ignores toplevel test directories (like
test
) so thatyotta test
can still be used with these modules.