ARNdroid / EasyTargetDiet

Android Easy Target Diet project.
4 stars 1 forks source link

Gradle buid: module dependencies refactoring #219

Open alceurneto opened 9 years ago

alceurneto commented 9 years ago

Today we have all subproject dependency declared inside each [etd/xxx]/build.gradle but most of them is equal for all modules.

We need a refactoring to extract all common dependency inside our root script EasyTargetDiet/build.gradle.

alceurneto commented 9 years ago

Our proposal:

EasyTargetDiet
==============
subprojects {
    dependencies {
        // Global (for all modules) dependencies here:
        compile 'com.android.support:appcompat-v7:22.1.1'
        compile 'com.android.support:support-v4:22.1.1'
        compile group: 'com.github.tony19', name: 'logback-android-core', version: '1.0.10-2'
        compile group: 'com.github.tony19', name: 'logback-android-classic', version: '1.0.10-2'
        compile group: 'org.slf4j', name: 'slf4j-api', version: '1.7.5'
        androidTestCompile group: 'com.google.dexmaker', name: 'dexmaker', version: '1.2'
        androidTestCompile group: 'com.google.dexmaker', name: 'dexmaker-mockito', version: '1.2'
        androidTestCompile group: 'org.mockito', name: 'mockito-core', version: '1.10.19'       
    }
}

etd-app
=======
dependencies {
    // Module specific dependencies here:
    compile project(':etd-shr')
}

etd-ptc
=======
dependencies {
    // Module specific dependencies here:
    compile project(':etd-api')
}

etd-api
=======
dependencies {
    // Module specific dependencies here:
    compile project(':etd-shr')
}

etd-shr
=======
dependencies {
    // No module specific dependencies yet.
}
ARNdroid commented 9 years ago

Implementing the proposed fix we're getting:

Error:(46, 0) Gradle DSL method not found: 'compile()'
Possible causes:
- The project 'EasyTargetDiet' may be using a version of Gradle that does not contain the method.
- The build file may be missing a Gradle plugin.

We need some research here.