format-overflow errors on fedora

[brancomat]

Impacts on f30/f31/f32

full logs:

https://travis-ci.org/github/ARPA-SIMC/meteosatlib/builds/692600831

relevant bit:

In file included from grib/grib.cpp:2:
In function 'void msat::grib::checked(int, const char*, const char*)',
    inlined from 'long int msat::grib::Grib::get_long_oneof(const char*, ...)' at grib/utils.h:202:16:
grib/utils.h:35:21: error: '%s' directive argument is null [-Werror=format-overflow=]
   35 |             CPLError(CE_Failure, CPLE_AppDefined, "%s %s: %s", func, context, grib_get_error_message(error));
      |             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function 'void msat::grib::checked(int, const char*, const char*)',
    inlined from 'double msat::grib::Grib::get_double_oneof(const char*, ...)' at grib/utils.h:244:16:
grib/utils.h:35:21: error: '%s' directive argument is null [-Werror=format-overflow=]
   35 |             CPLError(CE_Failure, CPLE_AppDefined, "%s %s: %s", func, context, grib_get_error_message(error));
      |             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function 'void msat::grib::checked(int, const char*, const char*)',
    inlined from 'void msat::grib::Grib::set_long_oneof(const char*, long int, ...)' at grib/utils.h:285:16:
grib/utils.h:35:21: error: '%s' directive argument is null [-Werror=format-overflow=]
   35 |             CPLError(CE_Failure, CPLE_AppDefined, "%s %s: %s", func, context, grib_get_error_message(error));
      |             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In member function 'virtual bool msat::grib::{anonymous}::CreateGRIB::create()',
    inlined from 'virtual bool msat::grib::{anonymous}::CreateGRIB::create()' at grib/grib.cpp:310:18:
grib/grib.cpp:316:21: error: '%s' directive argument is null [-Werror=format-overflow=]
  316 |             CPLError(CE_Failure, CPLE_AppDefined, "GRIB for satellites requires a " SRS_PT_GEOSTATIONARY_SATELLITE " projection, but we have %s", stype);
      |             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In member function 'virtual bool msat::grib::{anonymous}::CreateGRIB::create()',
    inlined from 'virtual bool msat::grib::{anonymous}::CreateGRIB::create()' at grib/grib.cpp:310:18,
    inlined from 'virtual bool msat::grib::{anonymous}::CreateGRIB1::create()' at grib/grib.cpp:778:32:
grib/grib.cpp:316:21: error: '%s' directive argument is null [-Werror=format-overflow=]
  316 |             CPLError(CE_Failure, CPLE_AppDefined, "GRIB for satellites requires a " SRS_PT_GEOSTATIONARY_SATELLITE " projection, but we have %s", stype);
      |             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In member function 'virtual bool msat::grib::{anonymous}::CreateGRIB::create()',
    inlined from 'virtual bool msat::grib::{anonymous}::CreateGRIB::create()' at grib/grib.cpp:310:18,
    inlined from 'virtual bool msat::grib::{anonymous}::CreateGRIB2::create()' at grib/grib.cpp:604:32:
grib/grib.cpp:316:21: error: '%s' directive argument is null [-Werror=format-overflow=]
  316 |             CPLError(CE_Failure, CPLE_AppDefined, "GRIB for satellites requires a " SRS_PT_GEOSTATIONARY_SATELLITE " projection, but we have %s", stype);
      |             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In member function 'virtual bool msat::grib::{anonymous}::CreateGRIB::create()',
    inlined from 'virtual bool msat::grib::{anonymous}::CreateGRIB::create()' at grib/grib.cpp:310:18,
    inlined from 'virtual bool msat::grib::{anonymous}::CreateGRIB1::create()' at grib/grib.cpp:778:32,
    inlined from 'GDALDataset* msat::grib::GRIBCreateCopy(const char*, GDALDataset*, int, char**, GDALProgressFunc, void*)' at grib/grib.cpp:847:26:
grib/grib.cpp:316:21: error: '%s' directive argument is null [-Werror=format-overflow=]
  316 |             CPLError(CE_Failure, CPLE_AppDefined, "GRIB for satellites requires a " SRS_PT_GEOSTATIONARY_SATELLITE " projection, but we have %s", stype);
      |             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In member function 'virtual bool msat::grib::{anonymous}::CreateGRIB::create()',
    inlined from 'virtual bool msat::grib::{anonymous}::CreateGRIB::create()' at grib/grib.cpp:310:18,
    inlined from 'virtual bool msat::grib::{anonymous}::CreateGRIB1::create()' at grib/grib.cpp:778:32,
    inlined from 'GDALDataset* msat::grib::GRIBCreateCopy(const char*, GDALDataset*, int, char**, GDALProgressFunc, void*)' at grib/grib.cpp:844:26:
grib/grib.cpp:316:21: error: '%s' directive argument is null [-Werror=format-overflow=]
  316 |             CPLError(CE_Failure, CPLE_AppDefined, "GRIB for satellites requires a " SRS_PT_GEOSTATIONARY_SATELLITE " projection, but we have %s", stype);
      |             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:732: grib/libmsatdrv_la-grib.lo] Error 1

[edigiacomo]

Fixed in 08781cc