search

ARPA-SIMC / meteosatlib

OpenMTP/HRI/HRIT C++ access libraries, gdal drivers and other tools
GNU General Public License v2.0
8 stars 2 forks source link

GDAL 3 support #19

Closed edigiacomo closed 4 years ago

edigiacomo commented 4 years ago

In this PR I have fixed issue #18, but now the build for Fedora32 (the only one with GDAL 3) fails for a missing key: https://travis-ci.org/github/ARPA-SIMC/meteosatlib/jobs/693403179

I don't merge it because I'm not 100% sure that it's an unrelated problem.

edigiacomo commented 4 years ago

Update: it seems that in Fedora 32 (eccodes-2.17) a key alias is changed from altitudeOfTheCameraFromTheEarthSCenterMeasuredInUnitsOfTheEarth to altitudeOfTheCameraFromTheEarthsCentreMeasuredInUnitsOfTheEarthsRadius

In Fedora 30 (eccodes-2.14)

$ $ grep -R altitudeOfTheCameraFromTheEarthSCenterMeasuredInUnitsOfTheEarth /usr/share/eccodes/
/usr/share/eccodes/definitions/grib2/template.3.90.def:alias altitudeOfTheCameraFromTheEarthSCenterMeasuredInUnitsOfTheEarth = Nr;
/usr/share/eccodes/definitions/grib1/grid_definition_90.def:alias altitudeOfTheCameraFromTheEarthSCenterMeasuredInUnitsOfTheEarth = NrInRadiusOfEarth;

In Fedora 32 (eccodes-2.17):

$ grep -R altitudeOfTheCamera /usr/share/eccodes/
/usr/share/eccodes/definitions/grib1/grid_definition_90.def:alias altitudeOfTheCameraFromTheEarthsCentreMeasuredInUnitsOfTheEarthsRadius = NrInRadiusOfEarth;
/usr/share/eccodes/definitions/grib2/template.3.90.def:alias altitudeOfTheCameraFromTheEarthsCentreMeasuredInUnitsOfTheEarthsRadius = Nr;

Then, I think that this PR can be safely merged and a new issue for the grib key should be opened.

edigiacomo commented 4 years ago

Update 2: I confirm that the key was renamed in version 2.17 https://confluence.ecmwf.int/display/ECC/ecCodes+version+2.17.0+released

I merge this PR and open another one for the grib key issue.