search

ARPA-SIMC / moncic-ci

Continuous integration tool and development helper.
GNU General Public License v2.0
2 stars 0 forks source link

ImageStorage and subclasses constructor #62

Closed edigiacomo closed 2 years ago

edigiacomo commented 2 years ago

ImageStorage constructor wants a Session object as first argument (https://github.com/ARPA-SIMC/moncic-ci/blob/v0.7-1/moncic/imagestorage.py#L319) but its subclasses wants a Moncic object as the first argument and call the parent constructor using this as first argument.

moncic/imagestorage.py:361: error: Argument 1 to "__init__" of "ImageStorage" has incompatible type "Moncic"; expected "Session"
moncic/imagestorage.py:374: error: Argument 1 to "__init__" of "ImageStorage" has incompatible type "Moncic"; expected "Session"

Session and Moncic seems interchangeable in this context, then I don't know what's the better fix.

spanezz commented 2 years ago

Good catch! Session is the right one, all the Moncic-typed arguments are effectively pass-through