search

ARPE-edu / arpe

GNU General Public License v3.0
2 stars 4 forks source link

CSS Styles moved to its own file and dash Store instead of global variables #14

Closed gomezag closed 3 years ago

gomezag commented 3 years ago

Moved styling to a css file of its own and uncluttered a bit appV2 file Also deleted Tdict global variable and replaced with dash store

ARPE-edu commented 3 years ago

Dear gomezag,

Thank you for your contribution. However, I need to decline it due to the following issues I would kindly ask to take a look again:

I like your changes, especially including the dcc.Store and would appreciate continuing on this topic with you.

Attached a Screenshot for better understanding.

Best regards and thank you in advance Screenshot , Patrick

gomezag commented 3 years ago

rewrote the commits using newest branch. Moved pull request to #17