ARPspoofing / pe

0 stars 0 forks source link

Sequence diagram return labels could be better #25

Open ARPspoofing opened 1 year ago

ARPspoofing commented 1 year ago

f is used for the return label which I understand is the object, however in that case, why is predicate used as the return label instead of p? I think for consistency, it will be better to label p and f instead of predicate and p.

Screenshot 2023-04-14 at 3.36.33 PM.png

nus-pe-script commented 1 year ago

Team's Response

Good catch. However, we feel that this does not affect usage and is purely a cosmetic flaw.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: Not a cosmetic issue, it has got to do with understanding the sequence diagram. It seems that everything is treated as a cosmetic issue to downgrade the severity of the bugs, which should not be the case.