ARPspoofing / pe

0 stars 0 forks source link

Phone number should be longer than 3 numbers #3

Open ARPspoofing opened 1 year ago

ARPspoofing commented 1 year ago

Understand that setting constraints on phone number is good. However, a valid phone number should be longer than 3 digits. Perhaps we could merge it with the telegram instead? After all, if an NUS TA has a choice, he/she would prefer to use the telegram handle over the phone number.

Steps to reproduce: add n/Wen Li e/e07123456@u.nus.edu p/912 a/Kent Ridge PGPR tele/@wenlisan r/Very hardworking :)

Screenshot of example execution:

Screenshot 2023-04-14 at 2.22.23 PM.png

nus-se-script commented 1 year ago

Team's Response

Fair point. We could have set the limit for the phone number to at least 8 digits such that this can at least prevent typos, but ultimately this isn't a critical feature flaw.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This should definitely not be rejected. I do not understand why you guys are justifying that a phone number being a minimum length of 3 digits is ok? Anyways, you acknowledged that it isn't a critical flaw (which I agree), and that it is a fair point, so why was this rejected? It seems that we both agree that it should have been set to a greater minimum length, and hence this should not be rejected.