search

ARS-SWRC / agwa

Toolbox and code (ArcPy/Python) for the Automated Geospatial Watershed Assessment tool (AGWA).
Other
6 stars 1 forks source link

join K2 results to feature join #2

Open bssheppard opened 3 months ago

bssheppard commented 3 months ago

though simulations were ran and imported, they did not show up to be joined and viewed:

image

Thanks for working on AGWApro! I will have more suggestions or recall some things from previous AGWA that I really liked in the not-too-distant future.

kennethelsner commented 3 months ago

First off, thank you all for creating AGWAPro... or whatever it will finally be advertised as. Second, the Tutorial for BAER is pretty thorough, so thank you again!

Third, I ran into the same issue above. This issue will limit our ability to integrate AGWA into our final products. AGWA_Step11__JoinandViewSimResults_Error

haiyan-Wei commented 3 months ago

Thank you for providing the screenshot of the error message. I am looking into this issue today. Sorry, I was away for a conference and just returned yesterday.

bssheppard commented 3 months ago

Hi Haiyan!!

Hope you are doing well!

Thanks for picking up AGWA, it must be a little difficult/different without Shea.

I will be adding some more comments sometime soon. A few of my favorite features are not included in the pro version.

-Scott

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Haiyan Wei @.> Sent: Friday, August 9, 2024 10:17:57 AM To: ARS-SWRC/agwa @.> Cc: Sheppard, Brian - FS, ID @.>; Author @.> Subject: Re: [ARS-SWRC/agwa] join K2 results to feature join (Issue #2)

Thank you for providing the screenshot of the error message. I am looking into this issue today. Sorry, I was away for a conference and just returned yesterday.

— Reply to this email directly, view it on GitHubhttps://github.com/ARS-SWRC/agwa/issues/2#issuecomment-2278395747, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BIAI3R34Z54AT7GB4WWXMJ3ZQT2ULAVCNFSM6AAAAABMAS6436VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYGM4TKNZUG4. You are receiving this because you authored the thread.Message ID: @.***>

This electronic message contains information generated by the USDA solely for the intended recipients. Any unauthorized interception of this message or the use or disclosure of the information it contains may violate the law and subject the violator to civil or criminal penalties. If you believe you have received this message in error, please notify the sender and delete the email immediately.

haiyan-Wei commented 3 months ago

Hi Scott, replacing Shea is simply impossible, but I’ll do my best. On Tuesday at the conference, I showed this message to Chandra and mentioned that you might be AGWA Pro User 0001. Thanks for testing the beta version. We will keep adding features to AGWA Pro, so feel free to list any features you’d like to be included, and we can prioritize those.

bssheppard commented 3 months ago

[heart] Sheppard, Brian - FS, ID reacted to your message:

From: Haiyan Wei @.> Sent: Friday, August 9, 2024 8:15:17 PM To: ARS-SWRC/agwa @.> Cc: Sheppard, Brian - FS, ID @.>; Author @.> Subject: Re: [ARS-SWRC/agwa] join K2 results to feature join (Issue #2)

Hi Scott, replacing Shea is simply impossible, but I’ll do my best. On Tuesday at the conference, I showed this message to Chandra and mentioned that you might be AGWA Pro User 0001. Thanks for testing the beta version. We will keep adding features to AGWA Pro, so feel free to list any features you’d like to be included, and we can prioritize those.

— Reply to this email directly, view it on GitHubhttps://github.com/ARS-SWRC/agwa/issues/2#issuecomment-2278677131, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BIAI3RYBPFKWURH7H2I53MLZQUPNLAVCNFSM6AAAAABMAS6436VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYGY3TOMJTGE. You are receiving this because you authored the thread.Message ID: @.***>

This electronic message contains information generated by the USDA solely for the intended recipients. Any unauthorized interception of this message or the use or disclosure of the information it contains may violate the law and subject the violator to civil or criminal penalties. If you believe you have received this message in error, please notify the sender and delete the email immediately.

haiyan-Wei commented 3 months ago

@bssheppard @kennethelsner Thank you for testing AGWA pro. We appreciate it.

I started from scratch following the tutorial and was not able to reproduce the error. However, from the screenshot @kennethelsner provided, I realized the line that caused the error was not necessary. I removed it, tested it again, and committed the changes. Would you please download the code, test Step 11 again, and report back?

If you still see the error message, could you do me a favor and check if a table named k2_results exists in E:\agwa_prj\learn_agwa\fire_demo\AndreasCanyon\AndreasCanyon.gdb? If it exists, could you open it and see if you can spot anything unusual?

Thanks!

kennethelsner commented 3 months ago

The updated python did the trick. Once I replaced the code, I was able to run Step 11 - Join and View.

In addition, I was able to complete step 13 - Compare Imported Sim Results and the pct difference looks spot on. image

Now if I only could figure out why the other Pour Point I am trying to model is bombing.

haiyan-Wei commented 3 months ago

That's awesome to hear! It is great to know AGWA pro worked in your watershed.

I’m curious, which version of ArcGIS Pro are you using? I wonder if we are using different versions, and if that explains why I didn’t encounter the same error.

Regarding the pour point that failed, there are a few things to consider:

If AGWA Pro crashed during the process, please feel free to share the error message (see Section 14.12 in the tutorial for instructions on how to retrieve error messages), and I’ll do my best to help.

kennethelsner commented 3 months ago

I am currently running 3.2.2 as is most of the Wildland Fire Community for the 2024 season.

I should have been more precise in my 'bombing' description of the other pour point. I am able to get to the point where I run the simluation. The simulation fails quickly with the following information.

image

IIRC, ArcMap AGWA had this issue when some soil characteristic were not parametrizing correctly. Looks like hillslope 231 along with others are right on the edge of a soil survey which may have some missing data. If this were the case, it would be awesome if AGWA could anticipate missing values during parametrization and create a pseudo value for the affected hillslopes so the model would run.

image

haiyan-Wei commented 3 months ago

That error might indeed be caused by missing soil data. When Shea and I last met, we discussed how to handle missing soil values. We’ll keep you updated, and whatever decision we make, we’ll ensure users are informed.

If it’s feasible, feel free to share your watershed delineation with me, and I’ll take a look at the soil data.

kennethelsner commented 3 months ago

I went ahead and used an adjacent & similar soil MUKEY on the problematic soil polygons (the problem soil was a small portion of the overall polygon) and the simulation worked as expected. Happy day.

bssheppard commented 3 months ago

You all are great! Good work team AGWA

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: kennethelsner @.> Sent: Friday, August 9, 2024 4:54:13 PM To: ARS-SWRC/agwa @.> Cc: Sheppard, Brian - FS, ID @.>; Mention @.> Subject: Re: [ARS-SWRC/agwa] join K2 results to feature join (Issue #2)

I went ahead and used an adjacent & similar soil MUKEY on the problematic soil polygons (the problem soil was a small portion of the overall polygon) and the simulation worked as expected. Happy day.

— Reply to this email directly, view it on GitHubhttps://github.com/ARS-SWRC/agwa/issues/2#issuecomment-2278889865, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BIAI3R6TSKPXOHZLU4ARFZTZQVJCLAVCNFSM6AAAAABMAS6436VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZYHA4DSOBWGU. You are receiving this because you were mentioned.Message ID: @.***>

This electronic message contains information generated by the USDA solely for the intended recipients. Any unauthorized interception of this message or the use or disclosure of the information it contains may violate the law and subject the violator to civil or criminal penalties. If you believe you have received this message in error, please notify the sender and delete the email immediately.

haiyan-Wei commented 3 months ago

I went ahead and used an adjacent & similar soil MUKEY on the problematic soil polygons (the problem soil was a small portion of the overall polygon) and the simulation worked as expected. Happy day.

That sounds like a great solution!

Captina commented 2 months ago

I feel odd getting a vintage error from this thread but I also got the same Step 11 error having just redownloaded everything today. That being said, I ignored it and it let me go on through 12 and 13 which generated the pct_diff shapefile that would end up being used in maps so thats neat and also a little hilarious

image

There are also a lot of negatives in the pct_diff table which is a bit concerning.

haiyan-Wei commented 2 months ago

Captina,

It is interesting that you got the same error in Step 11 that seemed to be fixed. I will double check the code. If it happens again, feel free to post a screenshot here. I am glad you were able to complete the simulation comparison without any issue for your watershed. It is true that the current AGWA look up table does not include all the texture types users may encounter in the gSSURGO database. Continuing developing reliable parameters for more texture types is on our todo list.

Best, Haiyan

On Sat, Sep 7, 2024 at 12:00 AM Captina @.***> wrote:

I feel odd getting a vintage error from this thread but I also got the same Step 11 error having just redownloaded everything today. That being said, I ignored it and it let me go on through 12 and 13 which generated the pct_diff shapefile that would end up being used in maps so thats neat and also a little hilarious

— Reply to this email directly, view it on GitHub https://github.com/ARS-SWRC/agwa/issues/2#issuecomment-2335096497, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMT4ZZ5GEV4T3TDN53OWA23ZVKQCVAVCNFSM6AAAAABMAS6436VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZVGA4TMNBZG4 . You are receiving this because you commented.Message ID: @.***>