ARTIST-Association / ARTIST

A differentiable ray tracer using the PyTorch machine-learning framework in Python.
MIT License
3 stars 0 forks source link

How to Present 4D Representations to the User? #69

Open kalebphipps opened 1 month ago

kalebphipps commented 1 month ago

Is your feature request related to a problem? Please describe. ARTIST uses a 4D representation for points and vectors. However, this representation may not be intuitive to a user, which could lead to confusion when creating configurations.

Describe the solution you'd like We should discuss the best way to deal with this - I see three possible options at the moment:

  1. Provide clear documentation and examples stating the 4D convention (already on the way) and assume the user is smart enough to follow these instructions.
  2. Provide clear documentation and examples and include checks within the ScenearioGenerator and ARTIST to ensure that the provided tensors have the appropriate shape and that the last entry is always a 0 for directions and 1 for points.
  3. Hide the 4D representation within the code, allow the user to provide 3D tensors as input and automatically adjust them within the code.

Once we have made a decision we should update this issue with the proposed solution and implement it!