Gks

[drosofff]

Tested on the IFB cloud. @mvdbeek can you see to incorporate the GKS logo in the galaxy-kickstart-base docker build, from group_vars/kickstart ?

[drosofff]

poke @mvdbeek

[mvdbeek]

@mvdbeek can you see to incorporate the GKS logo in the galaxy-kickstart-base docker build, from group_vars/kickstart ?

~~This would be exactly like for metavisitor: https://github.com/ARTbio/ansible-artimed/blob/master/group_vars/metavisitor#L26~~ I see, yes, we can actually point the Dockerfile to this inventory. The important lines are https://github.com/ARTbio/ansible-artimed/blob/master/dockerfiles/galaxy-kickstart/Dockerfile#L23 and https://github.com/ARTbio/ansible-artimed/blob/master/dockerfiles/galaxy-kickstart/Dockerfile#L56

Should I do this?

[mvdbeek]

Looks nice, 👍 .

[drosofff]

Should I do this?

Yes but I think it will be a bit less complicated after this PR is accepted

[drosofff]

@mvdbeek see my change in the [kickstart] welcome.html page at http://192.54.201.154

[mvdbeek]

@mvdbeek see my change in the [kickstart] welcome.html page at http://192.54.201.154.

I really would prefer exactly what they have done with galaxy main:

<p class="text-center"><small>Galaxy version {{ version_major.stdout }}, commit <code><a href="https://github.com/galaxyproject/galaxy/commit/{{ galaxy_changeset_id }}" target="_blank">{{ galaxy_changeset_id }}</a></code></small></p>

This is about galaxy, we really do not want users reporting problems with a changeset revision that corresponds to our Kickstart repo.

[mvdbeek]

The tests are failing now because the hosts files in the Dockerfile can't be found https://travis-ci.org/ARTbio/ansible-artimed/builds/134155037#L713 You would need to adjust the path in the Dockerfile to make this work.

[drosofff]

This line does not seems to work, for a while. ? . https://github.com/ARTbio/ansible-artimed/blob/3c5784a1da90e20575b8c1ecafacc382a1131b42/dockerfiles/galaxy-kickstart-artimed/Dockerfile#L8

[drosofff]

Please, You do the work on the template / Galaxy changeset after the merge of this PR. It takes me too much time.

[mvdbeek]

This line does not seems to work, for a while. ? . https://github.com/ARTbio/ansible-artimed/blob/3c5784a1da90e20575b8c1ecafacc382a1131b42/dockerfiles/galaxy-kickstart-artimed/Dockerfile#L8

yeah, I don't think we have ever used this to build artimed images. Could be removed I guess

[mvdbeek]

Nice work, let's merge it after the tests pass.