ARTbio / GalaxyKickStart

Ansible playbooks for Galaxy Server deployment
GNU General Public License v3.0
24 stars 22 forks source link

Local modifications to dependent roles #210

Closed dustin-cram closed 6 years ago

dustin-cram commented 7 years ago

I'm wondering if there is a recommended way to deal with local modifications to the dependent roles. Since those are downloaded with the ansible-galaxy script as opposed to being cloned, any changes I might make to them can't easily be maintained/tracked.

Or are others generally not modifying these for in-house changes?

mvdbeek commented 7 years ago

We generally try to contribute any changes back to the upstream repo. If you're testing locally you can just clone the roles in to the roles/ folder, those should take precedence over the remote roles. If you would like to use a fork of GalaxyKickStart and you need to modify any of the roles, you can fork these roles and add them to the requirements_roles.yml file

dustin-cram commented 7 years ago

Thanks @mvdbeek ,

I've had to make a couple changes to some of the roles because (I think) I'm targeting Ubuntu 16.04, not 14.04. I'll fork everything and adjust requirements_roles.yml as you suggest.

mvdbeek commented 7 years ago

We'd appreciate any Pull-requests for getting the roles working on 16.04 :).

dustin-cram commented 7 years ago

Yep, that's on my TODO list, right after - of course - making the fixes less ugly.

drosofff commented 7 years ago

Yep, thanks a lot. FYI, I remember that setting the postgresql_version variable to 9.5 or something in group_vars/all helps for Ubuntu 16.04

drosofff commented 7 years ago

@dustin-cram if you don't mind, I think we can close the issue. see PR #232