Open Pedram-Parsian opened 1 day ago
Thank you for your feedback!
We completely acknowledge the validity of all your critiques and suggestions. In fact, we identified these flaws earlier and rewrote the code about a year ago. However, due to some reasons, the updated version hasn’t been made public yet.
If you’re open to contributing, we’d love to collaborate. Please feel free to reach out to me directly at a.rahimi.aut@gmail.com, and we can discuss how to incorporate your thoughts into the new codebase and release it as soon as possible.
First, thank you for creating this useful library. I've noticed that developers often end up copying and modifying this code directly in their projects rather than using it as a dependency, likely due to its current structure and style. This pattern reduces community contributions and slows down the library's growth potential. By making the codebase more Pythonic and maintainable, we could encourage proper package usage and foster more community involvement.
I'd like to propose some structural and style improvements to make the codebase more Pythonic and maintainable.
Current Observations:
__Check_JDate_Validity__
) which should be reserved for name manglingget_tse_webid
and__Get_TSE_WebID__
Proposed Improvements:
Important Note on Backward Compatibility: These proposed changes would likely break backward compatibility with existing code. While this is a significant consideration, it might be worth considering a major version bump (e.g., v2.0.0) to implement these improvements. This would allow:
I'm happy to contribute these changes through a series of PRs if you're interested. Let me know if you'd like me to proceed with any specific part first.