unneeded LoC - Githubissues

ARudik / phc

Automatically exported from code.google.com/p/phc

0 stars 0 forks source link

unneeded LoC #115

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

Hi,
in the dataflow branch, file optimize/Prune_symbol_table.cpp
in line 130 the assignement is unnecessary because you pass in the vars
already as argument to the Analysis constructor. Just having one way of
getting vars ought to be enough i think.

Original issue reported on code.google.com by c...@gmx.de on 17 Oct 2009 at 1:40

GoogleCodeExporter commented 9 years ago

Seems right. Have you tested the change?

Original comment by paul.biggar on 17 Oct 2009 at 8:12

Added labels: ****
Removed labels: ****

GoogleCodeExporter commented 9 years ago

I gotta say I fear this. My personal alias analysis is not very good, but this 
change triggers a warning. It would need to be tested before doing this...

Original comment by paul.biggar on 22 Sep 2010 at 5:02

Added labels: ****
Removed labels: ****