search

ASASauqui / Spotify-custom-interface

Spotify custom interface project using Phoenix LiveView and the Spotify API.
0 stars 0 forks source link

Reconsider ecto usage #8

Open FeeJai opened 1 year ago

FeeJai commented 1 year ago

In the project you use ecto to define schemas. If I did not miss something, you however only use the auto-generated structs: https://elixir-lang.org/getting-started/structs.html

EctoSQL Query, Repo as well as migrations are not used (and probably not necessary either).

The schemas are not persisted into the database (Repo module). It seems that the project does currently not need a database (as long as login is oauth only), so I think you should consider removing the SpotifyInterface.Repo module and configuration, unless you want to persist data.

Note: This is not a necessary change, just a hint or an optional suggestion

FeeJai commented 1 year ago

More background info on the components of ecto: https://medium.com/@amandasposito/ecto-what-about-it-7c52b2dc3990