search

ASCOMInitiative / Conform

ASCOM Interface Conformance Checker
GNU General Public License v3.0
6 stars 2 forks source link

Conform camera - possible issue with expected failures #11

Open dougforpres opened 1 year ago

dougforpres commented 1 year ago

https://github.com/ASCOMInitiative/Conform/blob/fb671cea87c372a952c8be5b31ad3e5d40c9e804/Conform/Devices/CameraTester.vb#L1633-L1648

Hi, I've been conformance testing my Camera driver and think I have found an issue with the tests.

When testing "NumX/Y" and "StartX/Y", the driver is expected to throw an error if the value is out of range. But when testing "expected failures" the "CameraExposure" method deliberately manipulates those same properties with invalid values...

Example: When l_i is 1 (first time thru loop) CInt((m_CameraXSize / l_i) + 1)

So it will try to set NumX to be m_CameraXSize + 1, causing an out-of-range exception.

The test never gets to calling StartExposure, and the test fails :)

Am I misunderstanding something, or is this expected to fail?

Peter-Simpson commented 7 months ago

Hi Doug,

Sorry for the delay in replying! Yes, these tests are expected to fail, their intent is to confirm that the device rejects invalid values.

The comment on line 1632 indicates the purpose of the tests: 'StartExposure - Invalid Bin values

Best wishes, Peter