ASE-Workshop-2023 / tutorial

Tutorial site for the 2023 workshop "Open Science with the Atomic Simulation Environment"
https://ase-workshop-2023.github.io/tutorial
Other
2 stars 4 forks source link

TODO before workshop #2

Open lucydot opened 1 year ago

lucydot commented 1 year ago

Highest Priority

High priority

Can wait

ajjackson commented 1 year ago

Throwing down some notes here that could possibly be tidied into TODOs or separate issues:

prakayastha commented 1 year ago

Hi @lucydot - I'm putting down some general comments here but I am not sure about what proposed changes to make...

In episode 3, it seems like any input file that I read is not readable through the ASE version installed on the Daresbury computer. (code section 2 in episode 3) I have tried a different cif file from what was uploaded and a POSCAR. When I try to run the code on my local computer, it seems to work. So I am just flagging up that perhaps the version of ASE is causing an issue... This point is a high priority as the rest of the episode is dependent on this code.

In episode 4, the solution to "distorted sphalerite" gives an error "'list' object has no attribute 'translate'". And for "water animation" I am able to view the C60 but unable to see the moving atoms as a gif. I have a feeling this is again an issue of the ASE version installed because it works just fine on my local computer.

In episode 7, I am unable to import quippy.potential. I have to install quippy to pip install that is suggested in the Note above code patch 2, but I am unsuccessful in doing. As you had suggested in our previous discussion @lucydot - that the training environment should have this preinstalled, I would highly suggest if someone crosschecked this particular point.

In episode 8, pesudo_dir is not defined at line 376. This should be defined similarly to how it is in episode 9 such as "pseudo_dir = Path.home() / 'SSSP-1.2.1_PBE_efficiency'"

In episode 11, again quippy does not work for me so I am not able to test anything beyond line 247.

lucydot commented 1 year ago

Thanks @prakayastha, will take a look at these issues tomo. @ajjackson @pietrodelugas just at-ing you so you are kept int he loop.

lucydot commented 1 year ago

Hi @prakayastha thanks for catching these errors, v. useful!

In episode 3, it seems like any input file that I read is not readable through the ASE version installed on the Daresbury computer.

Problem fixed; the wget file was incorrect, so that the .cif file was actually html.

In episode 4, the solution to "distorted sphalerite" gives an error "'list' object has no attribute 'translate'".

Fixed! A line of code must have got lost in translation....

In episode 7, I am unable to import quippy.potential

I think this error may be related to filepaths, as if Quippy can't find potential filepath it throws a very unuseful error (as adam comments above). Now specifying a directory to unzip the potentials into, so others shouldn't face similar problem.

In episode 8, pesudo_dir is not defined at line 376. This should be defined similarly to how it is in episode 9 such as "pseudo_dir = Path.home() / 'SSSP-1.2.1_PBE_efficiency'"

Fixed!

lucydot commented 1 year ago

@ajjackson @pietrodelugas - getting an error running the QE code with mpi: CalledProcessError: Command '['mpirun', 'pw.x', '-in', 'espresso.pwi']' returned non-zero exit status 1.

For the first QE example

from calculations_in_parallel tutorial:

atoms = ase.build.bulk('Si')
atoms.calc = calc
atoms.get_potential_energy()

I guess we can discuss tomorrow; think it may not be finding the pw.x perhaps? QE example in following tutorial running fine so I think it is something not too difficult to solve.

lucydot commented 1 year ago

additional note here that I have swapped properties and dynamics slots in the online timetable to reflect the order we approach in the tutorial.