search

ASFHyP3 / SRG

Algorithm to provide deformation time series data for volcanic regions from space-geodetic InSAR and GNSS observations
3 stars 3 forks source link

Remove FFT Vendored Code #14

Open forrestfwilliams opened 8 months ago

forrestfwilliams commented 8 months ago

From @jhkennedy in PR #11 :

There's licensing issues with vendoring this library (fftw-3.3.9) -- if you vendor a GPL v2 library, you have also to license your code GPL compliant, which is not in line with NASA SMD policies to use a permissive license.

Because of this, we should make sure that we create a way to install the workflow in this repository without vendored code. Instead, we should install fftw from its source.

@kspepin would also enjoy your thoughts on this.

jhkennedy commented 8 months ago

Notably, FFTW 3.3.9 and 3.3.10 are available on conda-forge, so it should be straightforward to link to that instead: https://anaconda.org/conda-forge/fftw

kspepin commented 8 months ago

I think it would be okay to use a different version? Let's check with Howard to see what he thinks. If FFTW on conda-forge can easily be utilized by fortran and c then it shouldn't be a problem.

On Thu, Mar 28, 2024 at 1:25 PM Joseph H Kennedy @.***> wrote:

Notably, FFTW 3.3.9 and 3.3.10 are available on conda-forge, so it should be straightforward to link to that instead: https://anaconda.org/conda-forge/fftw

— Reply to this email directly, view it on GitHub https://github.com/ASFHyP3/back-projection/issues/14#issuecomment-2025848871, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWOVQ43Y5OCANCTGNUHPTM3Y2RN7ZAVCNFSM6AAAAABFNH2E36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVHA2DQOBXGE . You are receiving this because you were mentioned.Message ID: @.***>

forrestfwilliams commented 3 months ago

Closing as the vendored FFTW was removed in PR #17