search

ASFHyP3 / hyp3-autorift

A HyP3 plugin for feature tracking processing with AutoRIFT-ISCE
BSD 3-Clause "New" or "Revised" License
7 stars 2 forks source link

fix landsat 4/5 fft filename bug #164

Closed forrestfwilliams closed 2 years ago

forrestfwilliams commented 2 years ago

This PR makes a small change to the file path that FFT-filtered images are written to. Instead of writing them to /working/directory/{BASE_NAME}_fft.tif, we now write them to /working/directory/fft/{BASE_NAME}.tif. This ensures that routines that rely on string indexes of standard Landsat image names work correctly.

forrestfwilliams commented 2 years ago

No not currently, but the fact that we have no tests for this functionality may be a bigger issue.

forrestfwilliams commented 2 years ago

@jhkennedy and @jtherrmann, currently the create_fft_filepath function creates the directory in which the data is saved. I'm concerned this may be an inappropriate side effect for this function. Thoughts?

jtherrmann commented 2 years ago

@jhkennedy and @jtherrmann, currently the create_fft_filepath function creates the directory in which the data is saved. I'm concerned this may be an inappropriate side effect for this function. Thoughts?

@forrestfwilliams Yeah it may be better to create the directory right after this line, since it should be the same directory for both calls of the create_fft_filepath function, right? So no need to attempt to create it twice.