search

ASFHyP3 / hyp3-gamma

HyP3 plugin for generating SAR products with GAMMA
BSD 3-Clause "New" or "Revised" License
30 stars 7 forks source link

Gamma update 20220630 u2004 #393

Closed cirrusasf closed 2 years ago

cirrusasf commented 2 years ago
cirrusasf commented 2 years ago

After hyp3-gamma-20220630-with-ubuntu22.04 fails the golden test. I dig in and find out the problem begin at producing big.dem/bi.par. I tested the hyp3-gamma-20220630-with-ubuntu20.04, it can produce the same big.dem/big.par as the prod, I ran the version to produce the InSAR outputs and compared them with those produced by prod. I found the outputs are very close. I would like to test if the hyp3-gamma-20220630-with-ubuntu20.04 can pass golden test.

jhkennedy commented 2 years ago

@cirrusasf #391 was already merged to develop making changes for updating the GAMMA version, and this PR is based on an outdated version of develop: image

So you'll need to either rebase onto, or merge in, origin/develop. Then you'll need to look at that PR and change everything back to ubuntu 20.04, or revert that PR and then make the upgrade changes you want.

In general, you should start each feature branch from a latest develop branch.

asjohnston-asf commented 2 years ago

You'll also want to revert back to Python 3.8 in test-and-build.yml at: https://github.com/ASFHyP3/hyp3-gamma/blob/gamma-update-20220630-u2004/.github/workflows/test-and-build.yml#L25 https://github.com/ASFHyP3/hyp3-gamma/blob/gamma-update-20220630-u2004/.github/workflows/test-and-build.yml#L31

cirrusasf commented 2 years ago

After extensive tests, I found if I separate the resample and re-projection into two steps, then gdal 3.0.4 (ubuntu20.04) and gdal 3.4.1 (ubuntu22.04) produce the same dem.tif files. In order to upgrade to gamma-20220630-u2204, we have to use the separate logic to deal with resample and re-projection. So I suggest to modify the function prepare_dem_geotiff() in the dem.py.