ASFHyP3 / hyp3-gamma

HyP3 plugin for generating SAR products with GAMMA
BSD 3-Clause "New" or "Revised" License
30 stars 7 forks source link

Adjustable adf avo #447

Closed cirrusasf closed 1 year ago

cirrusasf commented 1 year ago
cirrusasf commented 1 year ago

@cirrusasf do you think we should also expose the width parameter? I'm leaning towards yes. https://github.com/ASFHyP3/hyp3-gamma/blob/develop/hyp3_gamma/insar/unwrapping_geocoding.py#L240

I checked the code as well as GAMMA doc, it looks like the width is called interferogram_width, it is obtained from the off.it file, and it is not a changeable parameter. So maybe we should not change this.

jhkennedy commented 1 year ago

I checked the code as well as GAMMA doc, it looks like the width is called interferogram_width, it is obtained from the off.it file, and it is not a changeable parameter. So maybe we should not change this.

Perfect. Then yes, I'd agree.

cirrusasf commented 1 year ago

I checked the code as well as GAMMA doc, it looks like the width is called interferogram_width, it is obtained from the off.it file, and it is not a changeable parameter. So maybe we should not change this.

Perfect. Then yes, I'd agree.

Good!