search

ASFHyP3 / hyp3-gamma

HyP3 plugin for generating SAR products with GAMMA
BSD 3-Clause "New" or "Revised" License
30 stars 7 forks source link

Change nodata in rtc dem #464

Closed cirrusasf closed 1 year ago

cirrusasf commented 1 year ago

See https://github.com/ASFHyP3/hyp3-gamma/issues/260

cirrusasf commented 1 year ago

Hi Jack, I will add the unit test for the function, thank you!

Jiang

On Mon, Jul 31, 2023 at 1:48 PM Jake Herrmann @.***> wrote:

@.**** commented on this pull request.

In hyp3_gamma/dem.py https://github.com/ASFHyP3/hyp3-gamma/pull/464#discussion_r1279917010:

@@ -99,11 +119,14 @@ def prepare_dem_geotiff(output_name: str, geometry: ogr.Geometry, pixel_size: fl with TemporaryDirectory() as temp_dir: temp_path = Path(temp_dir)

  • geometry = get_envelope_geometry(geometry)

That makes sense, thanks for the clarification. Can you add some unit tests for this function? We should probably have one test for a geometry that does not cross the anti-meridian, and another test for a geometry that crosses the anti-meridian.

— Reply to this email directly, view it on GitHub https://github.com/ASFHyP3/hyp3-gamma/pull/464#discussion_r1279917010, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO3CPWBA2SDJI7F2LNXOE4DXTAR4DANCNFSM6AAAAAAZQVIRNY . You are receiving this because you authored the thread.Message ID: @.***>

cirrusasf commented 1 year ago

We decide not to create the input dem.tif based on the envelope of map_overlay, only modify the code to produce the output dem.tif without setting nodata. New code passes local test. It is ready for review.