ASFHyP3 / hyp3-gamma

HyP3 plugin for generating SAR products with GAMMA
BSD 3-Clause "New" or "Revised" License
28 stars 7 forks source link

Incorrect Conversion from Shapefile to Water Mask Raster #507

Closed AndrewPlayer3 closed 8 months ago

AndrewPlayer3 commented 8 months ago

The bug

When 'Apply Water Mask' is selected, in some regions, the water mask incorrectly masks out most of the land and leads to incorrect unwrapping. Here is an example, from Switzerland, where you can see the image should be mostly land with a couple lakes. However, the water mask is all nodata. Screenshot 2023-10-30 at 1 09 01 PM Screenshot 2023-10-30 at 1 09 22 PM

To Reproduce

Here are the parameters for a job that fails:

"job_parameters": {
        "apply_water_mask": true,
        "granules": [
          "S1A_IW_SLC__1SDV_20230602T172346_20230602T172413_048810_05DEAA_9971",
          "S1A_IW_SLC__1SDV_20230614T172347_20230614T172414_048985_05E406_AD4A"
        ],
        "include_dem": false,
        "include_displacement_maps": true,
        "include_inc_map": false,
        "include_look_vectors": false,
        "include_wrapped_phase": true,
        "looks": "10x2"
      }