search

ASFHyP3 / hyp3-gamma

HyP3 plugin for generating SAR products with GAMMA
BSD 3-Clause "New" or "Revised" License
28 stars 7 forks source link

add shapely>=2.0 in the setup.py and environment.yml #511

Closed cirrusasf closed 8 months ago

asjohnston-asf commented 8 months ago

This could have unexpected impact on GAMMA and deserves testing. The GAMMA installation guide specifies installing python3-shapely via apt, suggesting GAMMA is expecting v1.8.

cirrusasf commented 8 months ago

Hi Andrew,

OK. We can try to get rid of using shapely.to_json() function, which is not available in shapely 1.8. We will refactor the code later.

Jiang

On Tue, Oct 31, 2023 at 4:41 PM Andrew Johnston @.***> wrote:

This could have unexpected impact on GAMMA and deserves testing. The GAMMA installation guide specifies installing python3-shapely via apt, suggesting GAMMA is expecting v1.8.

— Reply to this email directly, view it on GitHub https://github.com/ASFHyP3/hyp3-gamma/pull/511#issuecomment-1788225626, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO3CPWGNFOXAA4MYMX6JF4LYCGLCHAVCNFSM6AAAAAA6YQZ47KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYGIZDKNRSGY . You are receiving this because you authored the thread.Message ID: @.***>

cirrusasf commented 8 months ago

Hi Andrew,

I mean shapely.to_geojson(extent) is not available in shapely v 1.8.

Jiang

On Tue, Oct 31, 2023 at 5:04 PM Jiang Zhu @.***> wrote:

Hi Andrew,

OK. We can try to get rid of using shapely.to_json() function, which is not available in shapely 1.8. We will refactor the code later.

Jiang

On Tue, Oct 31, 2023 at 4:41 PM Andrew Johnston @.***> wrote:

This could have unexpected impact on GAMMA and deserves testing. The GAMMA installation guide specifies installing python3-shapely via apt, suggesting GAMMA is expecting v1.8.

— Reply to this email directly, view it on GitHub https://github.com/ASFHyP3/hyp3-gamma/pull/511#issuecomment-1788225626, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO3CPWGNFOXAA4MYMX6JF4LYCGLCHAVCNFSM6AAAAAA6YQZ47KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYGIZDKNRSGY . You are receiving this because you authored the thread.Message ID: @.***>