ASFHyP3 / hyp3-isce2

HyP3 plugin for ISCE2 processing
Apache License 2.0
11 stars 9 forks source link

hyp3_isce2_burst_merge tutorial failed at merging step #212

Open LiChiehLin opened 2 months ago

LiChiehLin commented 2 months ago

Hi all,

I followed the tutorial notebook from this: https://github.com/ASFHyP3/hyp3-docs/blob/develop/docs/tutorials/hyp3_isce2_burst_merge.ipynb and an error showed when it reached running hyp3_isce2 plugin

!python -m hyp3_isce2 ++process merge_tops_bursts $data_dir

Below is the error it showed. image I modified line 131 in merge_tops_bursts.py and it worked all the way to the end without any further errors.

start_utc = [
        datetime.datetime.strptime(result.properties['startTime'], '%Y-%m-%dT%H:%M:%SZ') for result in results
    ]

Is it possible the naming fashion had changed? Thanks!

forrestfwilliams commented 2 months ago

Hey @LiChiehLin apologies that this took us a while to get to. Turns out that when asf_search upgraded to v7.1.0 they dropped the fractional second start time information from startTime property in the properties attribute. In PR #216 we fix this by grabbing the start time information from the umm attribute instead.