ASFHyP3 / hyp3

A processing environment for HyP3 Plugins in AWS.
BSD 3-Clause "New" or "Revised" License
35 stars 8 forks source link

Update the INSAR_ISCE job definitions for new features from JPL #1446

Open jhkennedy opened 1 year ago

jhkennedy commented 1 year ago

JPL is working on a variety of updates to the ARIA-S1-GUNW products and would like to include the new option/parameters in the INSAR_ISCE_TEST and INSAR_ISCE job specs.

# Available in `INSAR_ISCE_TEST.yml`
- [ ] #1416 
- [ ] #1452
- [ ] #1451
- [ ] #1448
- [ ] #1447
- [ ] provide an option to turn on and off dense offsets
- [ ] provide an option to specify output product pixel spacing (90m or 30m)
- [ ] option to add an unfiltered coherence layer to INSAR_ISCE output 
# Available in `INSAR_ISCE.yml`
- [ ] #1416
- [ ] Option to specify a frame id for INSAR_ISCE jobs
- [ ] Option to enable Ionospheric correction in INSAR_ISCE output
- [ ] Option to enable Enhanced Spectral Diversity correction in INSAR_ISCE output
- [ ] Option to enable Solid Earth Tides correction in INSAR_ISCE output
- [ ] provide an option to turn on and off dense offsets
- [ ] provide an option to specify output product pixel spacing (90m or 30m)
- [ ] option to add an unfiltered coherence layer to INSAR_ISCE output 
cmarshak commented 1 year ago

This looks good. The unlinked issues are associated to event/custom based GUNW generation, i.e.

cmarshak commented 1 year ago

I would also say "provide an option to turn on and off coherence filtering" --> add layer for unfiltered coherence.

cmarshak commented 1 year ago

Small updates:

Frames @jhkennedy and @asjohnston-asf - https://github.com/ACCESS-Cloud-Based-InSAR/DockerizedTopsApp/pull/92 for the frame-id is ready to be merged. There may be changes to the frame convention, but that type of fix should be easy (just re-upload the geojson of frames). Testing this on the cloud will help a lot too for seeing if the overlap is sufficient.

Troposphere @mgovorcin added / in process of adding some functionality to the entrypoint for GUNW updates using rader to write hidden api files for various weather models here: https://github.com/dbekaert/RAiDER/pull/484. Our secrets are shared via AWS. Will need your help to make sure these can all work in concert via hyp3.

Ionosphere Plugin: in develop (PR and PR) are both merged so just waiting for the hyp3 release; we may update the ionosphere in the plugin space based on @dbekaert's request (see this discussion), but we can at least begin testing integration of GUNW with new layer into other workflows.

Solid Earth Tides Here is the PR for the plugin (same as above). It is nearly ready to merge.

cmarshak commented 1 year ago

This well aligns with @dbekaert's vision for the coming processing campaign captured here: https://github.com/ACCESS-Cloud-Based-InSAR/DockerizedTopsApp/discussions/87