ASHdevelopment / standards

ASH Development Standards
28 stars 13 forks source link

Add code coverage standard #170

Open ASH-Michael opened 6 years ago

ASH-Michael commented 6 years ago

Add general note under testing section that each app/addon should maintain a minimum of 75% branch coverage in acceptance, integration, and unit tests combined.

ASH-Elden commented 6 years ago

Just double checking but this is to be added directly under Testing before '8.1 Test Scripts' because the 75% code coverage is already listed in

ASH Front End Principles denote that branch coverage should be a minimum of 75% total test coverage, and 50% for tests not including acceptance tests.

That text is under Definition of Ready > 6. Code Coverage in the ember.d file

ASH-Michael commented 6 years ago

Good catch @ASH-Elden! I forgot that it was listed there.

ASH-Michael commented 6 years ago

Hmmm. Maybe we need to revisit this, unless we want it in 2 places.

What does the team think?