search

ASHdevelopment / standards

ASH Development Standards
28 stars 13 forks source link

formatting in General.md #174

Closed ASH-Michael closed 5 years ago

ASH-Michael commented 6 years ago

Carry over from stg.ashui.com standards

We have a spacing standards in JavaScript, CSS, and SASS to add a space after the colon of a property, but this is only specified in css.md currently.

Should we:

  1. Add formatting to javascript.md
  2. Move it out of css.md and add it to General.md
ASH-Elden commented 6 years ago

I think it would be better to move it to general. As it is general only has stuff for commenting. I think anything cross language/technology should go in general as it logically makes more sense to me.

ASH-Michael commented 6 years ago

Add spacing standards for CSS/SCSS and JavaScript in General.md Include examples

ASH-Michael commented 5 years ago

@ASH-Elden Did this ever get reviewed and approved?

There was a typo in the original standard that looks to have carried over to the new. In the example below, we specify "semicolon", but then display a "colon".

For properties, put a space after the semicolon (:)

ASH-Elden commented 5 years ago

yeah it got approved, I can't merge without approval. Although I don't think I linked the branch with this issue correctly so you don't see the stages of commit and such here

ASH-Michael commented 5 years ago

Yeah. You need to include the [fixes #174] or [closes #174] in the pull request title for it to link correctly.

ASH-Elden commented 5 years ago

I see, will do from now on. Sorry about that!