search

ASHdevelopment / standards

ASH Development Standards
28 stars 13 forks source link

Update with result of CAST querystring array discussion [closes #187] #189

Closed ASH-Bryan closed 5 years ago

ASH-Bryan commented 5 years ago

I just updated with link changes requested by @ASH-Michael previously. Also, he had this comment:

Can we lump these two examples into one code block with //bad and //good comments as we do in the rest of the code standards and put very simple statements as to why one method is bad and the other is good, and then link to the full documentation for back-end devs to benefit from, since these are front-end standards?

I'm a little reluctant to simplify this too much since it is the history for why this decision was made. On the other hand, I think our internal resource contains much of this detail, so I can also see the case for keeping our standards simple. Thoughts?

ASH-Michael commented 5 years ago

I still think that the way this standard is worded implies that both approaches can be used, while one is recommended and the other discouraged.

I think we should pick one and say this one is "good", and the other is "bad", like we do in our other code standards.

ASH-Michael commented 5 years ago

@ASH-Bryan After our team discussion, we agreed to remove everything from "Our back end architecture..." down in this PR.