search

ASKBOT / askbot-devel

Askbot is a Django/Python Q&A forum. **Contributors README**: https://github.com/ASKBOT/askbot-devel#how-to-contribute. Commercial hosting of Askbot and support are available at https://askbot.com
Other
1.56k stars 627 forks source link

Typical Askbot deployment contains three copies of tinymce, two of which are not used #202

Open AdamWill opened 10 years ago

AdamWill commented 10 years ago

This...seems sub-optimal. See https://bugzilla.redhat.com/show_bug.cgi?id=1000735#c10 .

Why does askbot ship with a copy of tinymce in one place, and then use the django staticfiles mechanism to copy it somewhere else when collectstatic is run? If you're going to bundle a modified copy of tinymce, why not just put it in the correct location in the first place, so you don't have to have it copied from the 'wrong' place to the 'right' place as part of 'collectstatic'? And it would probably be a good idea to stop including python-django-tinymce's own copy of tinymce and then doing nothing at all with it.

evgenyfadeev commented 9 years ago

The reason for this was at the time that Askbot has two extensions (upload file and image) to TinyMCE and the extensions were required to be placed in the TinyMCE source tree. Afaik there was no way to put extensions outside of the TinyMCE tree. So I've copied the tree and placed extensions there.

TinyMCE version in Askbot was not upgraded since and most likely won't be as soon there will be support of the new CKEditor. TinyMCE support likely won't be upgraded unless there is a compelling reason.